Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp

Issue 2832783003: [css-grid] Clearing the override height before layout (Closed)
Patch Set: Applied suggested changes. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp
diff --git a/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp b/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp
index 877cf7562ebf4d6db4739f634b073c95cf09c886..6f8e5aa38873f98df660ee278d12481defea0d42 100644
--- a/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp
+++ b/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp
@@ -281,11 +281,6 @@ LayoutUnit GridTrackSizingAlgorithmStrategy::LogicalHeightForChild(
SetGridItemNeedsLayout(child);
}
- // We need to clear the stretched height to properly compute logical height
- // during layout.
- if (child.NeedsLayout())
- child.ClearOverrideLogicalContentHeight();
-
child.LayoutIfNeeded();
GridAxis baseline_axis = GetLayoutGrid()->IsOrthogonalChild(child)
? kGridRowAxis

Powered by Google App Engine
This is Rietveld 408576698