third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp - Issue 2832783003: [css-grid] Clearing the override height before layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp

Issue 2832783003: [css-grid] Clearing the override height before layout (Closed)

Patch Set: Applied suggested changes. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp

diff --git a/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp b/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp

index 877cf7562ebf4d6db4739f634b073c95cf09c886..6f8e5aa38873f98df660ee278d12481defea0d42 100644

--- a/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp

+++ b/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp

@@ -281,11 +281,6 @@ LayoutUnit GridTrackSizingAlgorithmStrategy::LogicalHeightForChild(

SetGridItemNeedsLayout(child);

}

- // We need to clear the stretched height to properly compute logical height

- // during layout.

- if (child.NeedsLayout())

- child.ClearOverrideLogicalContentHeight();

child.LayoutIfNeeded();

GridAxis baseline_axis = GetLayoutGrid()->IsOrthogonalChild(child)

? kGridRowAxis