Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6239)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 2832693002: MD Settings: search mode shouldn't have overscrolls (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_main/settings_main.js
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.js b/chrome/browser/resources/settings/settings_main/settings_main.js
index 49397d85763e019f8ec3de52b9e70d4b0cde7833..0e43c54e5ec73b337807de8253e9059c24bed270 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.js
+++ b/chrome/browser/resources/settings/settings_main/settings_main.js
@@ -76,7 +76,9 @@ Polymer({
*/
pageVisibility: {
type: Object,
- value: function() { return {}; },
+ value: function() {
+ return {};
+ },
},
showAndroidApps: Boolean,
@@ -196,7 +198,7 @@ Polymer({
* @private
*/
updateOverscrollForPage_: function() {
- if (this.showPages_.about) {
+ if (this.showPages_.about || this.inSearchMode_) {
// Set overscroll directly to remove any existing overscroll that
// setOverscroll_ would otherwise preserve.
this.overscroll_ = 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698