third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartNetworkDataProvider.js - Issue 2832653002: DevTools: brush up color blending and theming APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartNetworkDataProvider.js

Issue 2832653002: DevTools: brush up color blending and theming APIs. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartNetworkDataProvider.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartNetworkDataProvider.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartNetworkDataProvider.js

index d066c156a6561e53b67bd5dd90fd8dcaf28f252f..60c966bd0746d6f5491ce8dd110730a75a839be8 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartNetworkDataProvider.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartNetworkDataProvider.js

@@ -14,9 +14,9 @@ Timeline.TimelineFlameChartNetworkDataProvider = class {

padding: 4,

height: 17,

collapsible: true,

- color: UI.themeSupport.patchColor('#222', UI.ThemeSupport.ColorUsage.Foreground),

+ color: UI.themeSupport.patchColorText('#222', UI.ThemeSupport.ColorUsage.Foreground),

font: this._font,

- backgroundColor: UI.themeSupport.patchColor('white', UI.ThemeSupport.ColorUsage.Background),

+ backgroundColor: UI.themeSupport.patchColorText('white', UI.ThemeSupport.ColorUsage.Background),

nestingLevel: 0,

useFirstLineForOverview: false,

useDecoratorsForOverview: true,

@@ -205,7 +205,7 @@ Timeline.TimelineFlameChartNetworkDataProvider = class {

context.fillStyle = 'hsla(0, 100%, 100%, 0.8)';

context.fillRect(sendStart + 0.5, barY + 0.5, headersEnd - sendStart - 0.5, barHeight - 2);

- context.fillStyle = UI.themeSupport.patchColor('white', UI.ThemeSupport.ColorUsage.Background);

+ context.fillStyle = UI.themeSupport.patchColorText('white', UI.ThemeSupport.ColorUsage.Background);

context.fillRect(barX, barY - 0.5, sendStart - barX, barHeight);

context.fillRect(finish, barY - 0.5, barX + barWidth - finish, barHeight);