components/printing/service/public/interfaces/pdf_compositor.mojom - Issue 2832633002: Add PDF compositor service

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/printing/service/public/interfaces/pdf_compositor.mojom

Issue 2832633002: Add PDF compositor service (Closed)

Patch Set: rebase more Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/printing/service/public/cpp/pdf_compositor_client.cc ('K') | « components/printing/service/public/interfaces/OWNERS ('k') | content/browser/service_manager/service_manager_context.cc » ('j') | content/browser/utility_process_host_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module printing.mojom;

	6

	7 const string kServiceName = "pdf_compositor";

	8

	9 // TODO(weili): Add support for printing frames from different processes.

	10 // Currently directly convert passed in page data to a PDF file.

	11 interface PdfCompositor {

	12 // Composite content from one or more subframes, and convert into a PDF file.
	dcheng 2017/05/10 07:36:48 This comment doesn't seem entirely accurate at the This comment doesn't seem entirely accurate at the moment, it seems like this is just about turning one skp into a pdf. So for now, maybe let's just keep the comment about that, and update it when we add subframe support per the TODO? Wei Li 2017/05/11 16:53:02 Updated. Show quoted text On 2017/05/10 07:36:48, dcheng wrote: > This comment doesn't seem entirely accurate at the moment, it seems like this is > just about turning one skp into a pdf. So for now, maybe let's just keep the > comment about that, and update it when we add subframe support per the TODO? Updated.
	13 // \|sk_handle\| points to a buffer of a Skia MultiPictureDocument.

	14 // \|pdf_handle\| points to the generated PDF file buffer.

	15 CompositePdf(handle<shared_buffer> sk_handle)

	16 => (handle<shared_buffer> pdf_handle);
	dcheng 2017/05/10 07:36:48 Realistically, how large do we expect these buffer Realistically, how large do we expect these buffers to be? Is it possible we'll run into shmem limits by passing this over shared memory? Wei Li 2017/05/11 16:53:02 For web pages, skia document buffer is smaller tha Show quoted text On 2017/05/10 07:36:48, dcheng wrote: > Realistically, how large do we expect these buffers to be? Is it possible we'll > run into shmem limits by passing this over shared memory? For web pages, skia document buffer is smaller than generated pdf file as it is more compact. For generated pdf file, the current code without this CL passes it using shared memory from renderer to browser without problem. In general, for rich webpages such as nytimes.com, theverge.com, the size is around a few megabytes. There is one caveat when we load a large pdf file directly, skia redrawing might generate large output. In this case, we should not call CompositePdf() [as we don't need to].
	17 };

OLD	NEW