printing/common/BUILD.gn - Issue 2832633002: Add PDF compositor service

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: printing/common/BUILD.gn

Issue 2832633002: Add PDF compositor service (Closed)

Patch Set: rebase again Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("common") {
	Lei Zhang 2017/04/27 22:42:21 Is printing/common meant to be code that can run i Is printing/common meant to be code that can run in any process? Wei Li 2017/04/29 04:35:18 In general, common/ directory contains code shared Show quoted text On 2017/04/27 22:42:21, Lei Zhang wrote: > Is printing/common meant to be code that can run in any process? In general, common/ directory contains code shared by browser and renderer. This source_set contains code independent to other parts of code except base and skia, so it can be run in any process. Lei Zhang 2017/05/04 01:31:09 I guess we can start splitting up printing/ a bit. Show quoted text On 2017/04/29 04:35:18, Wei Li wrote: > On 2017/04/27 22:42:21, Lei Zhang wrote: > > Is printing/common meant to be code that can run in any process? > > In general, common/ directory contains code shared by browser and renderer. This > source_set contains code independent to other parts of code except base and > skia, so it can be run in any process. I guess we can start splitting up printing/ a bit. Traditionally it's been just a mixed bag. Wei Li 2017/05/04 18:18:28 Acknowledged. Show quoted text On 2017/05/04 01:31:09, Lei Zhang wrote: > On 2017/04/29 04:35:18, Wei Li wrote: > > On 2017/04/27 22:42:21, Lei Zhang wrote: > > > Is printing/common meant to be code that can run in any process? > > > > In general, common/ directory contains code shared by browser and renderer. > This > > source_set contains code independent to other parts of code except base and > > skia, so it can be run in any process. > > I guess we can start splitting up printing/ a bit. Traditionally it's been just > a mixed bag. Acknowledged.
	6 sources = [

	7 "pdf_metafile_utils.cc",

	8 "pdf_metafile_utils.h",

	9 ]

	10

	11 deps = [

	12 "//base",

	13 "//skia",

	14 ]

	15 }

OLD	NEW

« content/public/app/mojo/content_utility_manifest.json ('K') | « printing/BUILD.gn ('k') | printing/common/pdf_metafile_utils.h » ('j') | printing/common/pdf_metafile_utils.h » ('J')