chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelsUpdater.java - Issue 2832493002: [Android O] Only delete legacy notification channels on upgrade

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelsUpdater.java

Issue 2832493002: [Android O] Only delete legacy notification channels on upgrade (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelsInitializer.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelsUpdater.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelsUpdater.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelsUpdater.java

index 19c16eb7014fbe34146b1a45e1e3eb81c1494c8b..8a7a1a95eceb3acdf8c70d5c9811495737877357 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelsUpdater.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelsUpdater.java

@@ -59,8 +59,7 @@ public class ChannelsUpdater {

public void updateChannels() {

if (!mIsAtLeastO) return;

assert mChannelsInitializer != null;

- // TODO(crbug.com/710843) Iterate through existing channels instead of deleting them all.

- mChannelsInitializer.deleteAllChannels();

+ mChannelsInitializer.deleteLegacyChannels();

mChannelsInitializer.initializeStartupChannels();

storeChannelVersionInPrefs();

}