Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2832403002: merge PrecedenceInfo into TokenType and update all refs (Closed)

Created:
3 years, 8 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

merge PrecedenceInfo into TokenType and update all refs * replace PrecedenceInfo *_INFO with TokenType.* * remove outdated PrecedenceInfo tests * delete unused precedence_info.dart R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/684065855fc894347237852da466ee32b14b6785

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+495 lines, -917 lines) Patch
M pkg/analyzer/lib/src/dart/scanner/scanner.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/token_utils.dart View 7 chunks +79 lines, -233 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 6 chunks +13 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 6 chunks +13 lines, -27 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 37 chunks +84 lines, -80 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/error_token.dart View 2 chunks +1 line, -3 lines 0 comments Download
D pkg/front_end/lib/src/fasta/scanner/precedence.dart View 1 chunk +0 lines, -289 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/recover.dart View 4 chunks +5 lines, -7 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 6 chunks +7 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 9 chunks +259 lines, -96 lines 0 comments Download
M pkg/front_end/test/fasta/parser/token_stream_rewriter_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/precedence_info_test.dart View 4 chunks +1 line, -119 lines 0 comments Download
M pkg/front_end/test/scanner_replacement_test.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/scanner_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
danrubel
3 years, 8 months ago (2017-04-23 20:12:08 UTC) #2
scheglov
LGTM
3 years, 8 months ago (2017-04-23 21:54:20 UTC) #3
danrubel
Committed patchset #1 (id:1) manually as 684065855fc894347237852da466ee32b14b6785 (presubmit successful).
3 years, 8 months ago (2017-04-25 12:51:59 UTC) #5
ahe
3 years, 6 months ago (2017-05-31 13:38:07 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698