Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2832353003: Clarify units for timeout (Closed)

Created:
3 years, 8 months ago by Nate Bosch
Modified:
3 years, 7 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, terry
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clarify units for timeout This is indicated in the linked MDN doc, but we should not make readers go looking. Also fix a typo. BUG=https://github.com/dart-lang/sdk/issues/29428 R=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/bbc65073fad1faf2b8a61cc167e3251ee159dd2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/dom/docs/docs.json View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Nate Bosch
3 years, 8 months ago (2017-04-22 01:30:45 UTC) #2
Alan Knight
lgtm
3 years, 7 months ago (2017-05-05 17:01:28 UTC) #3
Nate Bosch
3 years, 7 months ago (2017-05-05 17:11:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bbc65073fad1faf2b8a61cc167e3251ee159dd2e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698