Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 283233002: Cast: Fix udp_transport_unittest (Closed)

Created:
6 years, 7 months ago by hubbe
Modified:
6 years, 7 months ago
Reviewers:
miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cast: Fix udp_transport_unittest Currently, UdpTransport.SendAndReceive hangs forever if the hardcoded port it tries to use is occupied. This change makes it use a free local port instead. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271055

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment moved #

Patch Set 3 : comment moved #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -5 lines) Patch
M media/cast/cast_testing.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A media/cast/test/utility/net_utility.h View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A media/cast/test/utility/net_utility.cc View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M media/cast/transport/transport/udp_transport_unittest.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
hubbe
6 years, 7 months ago (2014-05-14 22:22:07 UTC) #1
miu
lgtm https://codereview.chromium.org/283233002/diff/1/media/cast/test/utility/net_utility.cc File media/cast/test/utility/net_utility.cc (right): https://codereview.chromium.org/283233002/diff/1/media/cast/test/utility/net_utility.cc#newcode17 media/cast/test/utility/net_utility.cc:17: // Determine a unused UDP port for the ...
6 years, 7 months ago (2014-05-15 02:48:47 UTC) #2
hubbe
https://codereview.chromium.org/283233002/diff/1/media/cast/test/utility/net_utility.cc File media/cast/test/utility/net_utility.cc (right): https://codereview.chromium.org/283233002/diff/1/media/cast/test/utility/net_utility.cc#newcode17 media/cast/test/utility/net_utility.cc:17: // Determine a unused UDP port for the in-process ...
6 years, 7 months ago (2014-05-16 01:04:45 UTC) #3
hubbe
The CQ bit was checked by hubbe@chromium.org
6 years, 7 months ago (2014-05-16 01:04:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/283233002/40001
6 years, 7 months ago (2014-05-16 01:06:05 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 04:05:32 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 05:10:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/27681)
6 years, 7 months ago (2014-05-16 05:10:32 UTC) #8
hubbe
The CQ bit was checked by hubbe@chromium.org
6 years, 7 months ago (2014-05-16 17:15:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/283233002/40001
6 years, 7 months ago (2014-05-16 17:15:47 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 18:14:49 UTC) #11
Message was sent while issue was closed. 
Change committed as 271055

Powered by Google App Engine
This is Rietveld 408576698