Issue 2832313002: Exclude files from FileSelectChooser if they can't convert to WebStrings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2832313002: Exclude files from FileSelectChooser if they can't convert to WebStrings. (Closed)

Created:
3 years, 8 months ago by Charlie Reis

Modified:
3 years, 6 months ago

Reviewers:
asanka, dcheng

CC:
chromium-reviews, ncarter (slow)

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

More Reviews

Description

Exclude files from FileSelectChooser if they can't convert to WebStrings. BUG=703303 TEST=See bug for repro steps. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2811533002 Cr-Commit-Position: refs/heads/master@{#466118} (cherry picked from commit e30abe9ad8527585fc6783d8abd24842b07f67b6)

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -1 line)			Patch
M	content/browser/frame_host/render_frame_host_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_manager_browsertest.cc	View	1 chunk	+62 lines, -0 lines	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	2 chunks	+18 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages