Fifo order should be preserved for messages on associated interfaces.

mojo/public/js/router.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 define("mojo/public/js/router", [
   "mojo/public/js/connector",
   "mojo/public/js/core",
   "mojo/public/js/interface_types",
   "mojo/public/js/lib/interface_endpoint_handle",
   "mojo/public/js/lib/pipe_control_message_handler",
@@ skipping 54 matching lines @@
     this.connector_ = new Connector(handle);
 
     this.connector_.setIncomingReceiver({
         accept: this.accept.bind(this),
     });
     this.connector_.setErrorHandler({
         onError: this.onPipeConnectionError.bind(this),
     });
 
     this.setInterfaceIdNamespaceBit_ = setInterfaceIdNamespaceBit;
+    this.cachedMessageData = null;

[yzshen1, 2017/04/24 17:30:46]

nit: Please consider commenting on the meaning of this field.

[wangjimmy, 2017/04/24 19:03:35]

Done.

     this.controlMessageHandler_ = new PipeControlMessageHandler(this);
     this.controlMessageProxy_ = new PipeControlMessageProxy(this.connector_);
     this.nextInterfaceIdValue_ = 1;
     this.encounteredError_ = false;
     this.endpoints_ = new Map();
   }
 
   Router.prototype.associateInterface = function(handleToSend) {
     if (!handleToSend.pendingAssociation()) {
       return types.kInvalidInterfaceId;
@@ skipping 40 matching lines @@
     check(endpoint);
     check(!endpoint.client);
     check(!endpoint.closed);
     endpoint.client = interfaceEndpointClient;
 
     if (endpoint.peerClosed) {
       timer.createOneShot(0,
           endpoint.client.notifyError.bind(endpoint.client));
     }
 
+    if (this.cachedMessageData && interfaceEndpointHandle.id() ===
+            this.cachedMessageData.message.getInterfaceId()) {
+      var ok = interfaceEndpointClient.handleIncomingMessage(

[yzshen1, 2017/04/24 17:30:45]

We are not supposed to call it synchronously. Because this will re-enter users'
code.

Imagine the user calls:

var associated_binding = new AssociatedBindings(..., new FooImpl(), ...);

If we call into "handleIncomingMessage" synchronously, that means FooImpl's
methods may be called before newAssociatedBindings() returns.

[wangjimmy, 2017/04/24 19:03:35]

Done.

+          this.cachedMessageData.message,
+          this.cachedMessageData.messageValidator);
+
+      if (!ok) {
+        this.handleInvalidIncomingMessage_();
+      }
+      this.connector_.resumeIncomingMethodCallProcessing();
+    }
+
     return endpoint;
   };
 
   Router.prototype.detachEndpointClient = function(
       interfaceEndpointHandle) {
     check(types.isValidInterfaceId(interfaceEndpointHandle.id()));
     var endpoint = this.endpoints_.get(interfaceEndpointHandle.id());
     check(endpoint);
     check(endpoint.client);
     check(!endpoint.closed);
@@ skipping 47 matching lines @@
       } else {
         var interfaceId = message.getInterfaceId();
         var endpoint = this.endpoints_.get(interfaceId);
         if (!endpoint || endpoint.closed) {
           return true;
         }
 
         if (!endpoint.client) {
           // We need to wait until a client is attached in order to dispatch
           // further messages.
-          // TODO(wangjimmy): Cache the message and send when the appropriate
-          // endpoint client is attached.
+          this.cachedMessageData = {message: message,
+              messageValidator: messageValidator};
+          this.connector_.pauseIncomingMethodCallProcessing();
           return false;

[yzshen1, 2017/04/24 17:30:45]

I think we should return "true" to mean "the message processing succeeded"?
I understand this return value is not currently used by the Connector.

[wangjimmy, 2017/04/24 19:03:35]

Done.

         }
         ok = endpoint.client.handleIncomingMessage(message, messageValidator);
       }
     }
 
     if (!ok) {
       this.handleInvalidIncomingMessage_();
     }
     return ok;
   };
@@ skipping 86 matching lines @@
     }
     if (endpoint.closed && endpoint.peerClosed) {
       this.endpoints_.delete(endpoint.id);
     }
   };
 
   var exports = {};
   exports.Router = Router;
   return exports;
 });