Clipboard Android - Store and Read Last Modified Time from Prefs

chrome/browser/chrome_browser_main_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main_android.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/path_service.h"
 #include "base/task_scheduler/post_task.h"
 #include "base/trace_event/trace_event.h"
 #include "chrome/browser/android/mojo/chrome_interface_registrar_android.h"
+#include "chrome/browser/android/preferences/clipboard_android.h"
 #include "chrome/browser/android/seccomp_support_detector.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/descriptors_android.h"
 #include "components/crash/content/app/breakpad_linux.h"
 #include "components/crash/content/browser/crash_dump_manager_android.h"
 #include "components/signin/core/browser/signin_manager.h"
 #include "content/public/browser/android/compositor.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/common/main_function_params.h"
 #include "net/android/network_change_notifier_factory_android.h"
@@ skipping 64 matching lines @@
 
   // Previously we stored information related to salient images for bookmarks
   // in a local file. We replaced the salient images with favicons. As part
   // of the clean up, the local file needs to be deleted. See crbug.com/499415.
   base::FilePath bookmark_image_file_path =
       profile()->GetPath().Append("BookmarkImageAndUrlStore.db");
   content::BrowserThread::PostDelayedTask(
       content::BrowserThread::FILE, FROM_HERE,
       base::Bind(&DeleteFileTask, bookmark_image_file_path),
       base::TimeDelta::FromMinutes(1));
+
+  // Idempotent.  Needs to be called once on startup.  If
+  // InitializeClipboardAndroidFromLocalState() is called multiple times (e.g.,
+  // once per profile load), that's okay; the additional calls don't change

[Bernhard Bauer, 2017/04/27 09:27:17]

Just for the sake of completeness: There aren't actually multiple profiles on
Android (incognito notwithstanding).

[Mark P, 2017/04/27 19:25:59]

Thanks for the remark.  Did you want me to add that comment?  I think it makes
things more confusing.  (There aren't actually multiple profiles, yet there is
incognito, and doesn't that mean this gets called again here?)

Left as-is.  If you reply after I submit this and want a comment change, I'm
happy to oblige.

Or I can remove the comment entirely, or maybe instead put a comment like this
by the definition of InitClipboardAndroidFromLocalState().
// Idempotent.  If called multiple times wit the same |local_state| parameter,
that's okay; the additional calls don't change anything.

+  // anything.
+  android::InitClipboardAndroidFromLocalState(g_browser_process->local_state());
+
   // Start watching the preferences that need to be backed up backup using
   // Android backup, so that we create a new backup if they change.
   backup_watcher_.reset(new chrome::android::ChromeBackupWatcher(profile()));
 }
 
 void ChromeBrowserMainPartsAndroid::PreEarlyInitialization() {
   TRACE_EVENT0("startup",
     "ChromeBrowserMainPartsAndroid::PreEarlyInitialization")
   net::NetworkChangeNotifier::SetFactory(
       new net::NetworkChangeNotifierFactoryAndroid());
@@ skipping 28 matching lines @@
       FROM_HERE, base::TaskTraits().MayBlock().WithPriority(
                      base::TaskPriority::BACKGROUND),
       base::Bind(&ReportSeccompSupport), base::TimeDelta::FromMinutes(1));
 
   RegisterChromeJavaMojoInterfaces();
 }
 
 void ChromeBrowserMainPartsAndroid::ShowMissingLocaleMessageBox() {
   NOTREACHED();
 }