swarming: mechanical changes to unit tests

appengine/swarming/handlers_bot_test.py

 #!/usr/bin/env python
 # coding: utf-8
 # Copyright 2015 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 import base64
 import datetime
 import logging
 import os
 import random
 import StringIO
 import sys
 import unittest
 import zipfile
 
 # Setups environment.
 import test_env_handlers
 
 from google.appengine.api import datastore_errors
 from google.appengine.ext import ndb
 
 import webapp2
 import webtest
 
+import handlers_backend
 import handlers_bot
 from components import ereporter2
 from components import utils
 from server import bot_archive
 from server import bot_auth
 from server import bot_code
 from server import bot_groups_config
 from server import bot_management
 from server import stats
 
@@ skipping 11 matching lines @@
         app,
         extra_environ={
           'REMOTE_ADDR': self.source_ip,
           'SERVER_SOFTWARE': os.environ['SERVER_SOFTWARE'],
         })
     self.mock(
         ereporter2, 'log_request',
         lambda *args, **kwargs: self.fail('%s, %s' % (args, kwargs)))
     # Bot API test cases run by default as bot.
     self.set_as_bot()
+    self._enqueue_task_orig = self.mock(
+        utils, 'enqueue_task', self._enqueue_task)
+
+  def _enqueue_task(self, url, queue_name, **kwargs):
+    if queue_name == 'task-dimensions':
+      # Call directly into it.
+      handlers_backend.TaskDimensionsHandler.tidy_stale(kwargs['payload'])

[Vadim Sh., 2017/04/26 21:30:20]

note that this may incorrectly inherit transaction context of the caller. Maybe
use ndb.non_transactional around _enqueue_task for completness.

[M-A Ruel, 2017/04/26 21:47:43]

Done.

+      return True
+    if queue_name == 'pubsub':
+      return True
+    self.fail(url)
 
   def test_handshake(self):
     errors = []
     def add_error(request, source, message):
       self.assertTrue(request)
       self.assertEqual('bot', source)
       errors.append(message)
     self.mock(ereporter2, 'log_request', add_error)
     params = {
       'dimensions': {
@@ skipping 1070 matching lines @@
     self.app.get('/bot_code?tok=%s' % tok, status=200)
 
 
 if __name__ == '__main__':
   if '-v' in sys.argv:
     unittest.TestCase.maxDiff = None
   logging.basicConfig(
       level=logging.DEBUG if '-v' in sys.argv else logging.CRITICAL,
       format='%(levelname)-7s %(filename)s:%(lineno)3d %(message)s')
   unittest.main()