Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 283223003: Add additional case where we use the use-dart2js-libraries flag in test.dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 1379 matching lines...) Expand 10 before | Expand all | Expand 10 after
1390 args.add(packageRoot); 1390 args.add(packageRoot);
1391 } 1391 }
1392 args.addAll(additionalOptions(filePath)); 1392 args.addAll(additionalOptions(filePath));
1393 if (configuration['analyzer']) { 1393 if (configuration['analyzer']) {
1394 args.add('--machine'); 1394 args.add('--machine');
1395 args.add('--no-hints'); 1395 args.add('--no-hints');
1396 } 1396 }
1397 1397
1398 if ((configuration["compiler"] == "dartanalyzer" || 1398 if ((configuration["compiler"] == "dartanalyzer" ||
1399 configuration["compiler"] == "dart2analyzer") && 1399 configuration["compiler"] == "dart2analyzer") &&
1400 filePath.filename.contains("dart2js")) { 1400 (filePath.filename.contains("dart2js") ||
1401 filePath.directoryPath.segments().last.contains('html_common'))) {
1401 args.add("--use-dart2js-libraries"); 1402 args.add("--use-dart2js-libraries");
1402 } 1403 }
1403 1404
1404 bool isMultitest = optionsFromFile["isMultitest"]; 1405 bool isMultitest = optionsFromFile["isMultitest"];
1405 List<String> dartOptions = optionsFromFile["dartOptions"]; 1406 List<String> dartOptions = optionsFromFile["dartOptions"];
1406 1407
1407 assert(!isMultitest || dartOptions == null); 1408 assert(!isMultitest || dartOptions == null);
1408 if (dartOptions == null) { 1409 if (dartOptions == null) {
1409 args.add(filePath.toNativePath()); 1410 args.add(filePath.toNativePath());
1410 } else { 1411 } else {
(...skipping 806 matching lines...) Expand 10 before | Expand all | Expand 10 after
2217 * $pass tests are expected to pass 2218 * $pass tests are expected to pass
2218 * $failOk tests are expected to fail that we won't fix 2219 * $failOk tests are expected to fail that we won't fix
2219 * $fail tests are expected to fail that we should fix 2220 * $fail tests are expected to fail that we should fix
2220 * $crash tests are expected to crash that we should fix 2221 * $crash tests are expected to crash that we should fix
2221 * $timeout tests are allowed to timeout 2222 * $timeout tests are allowed to timeout
2222 * $compileErrorSkip tests are skipped on browsers due to compile-time error 2223 * $compileErrorSkip tests are skipped on browsers due to compile-time error
2223 """; 2224 """;
2224 print(report); 2225 print(report);
2225 } 2226 }
2226 } 2227 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698