Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chromecast/browser/renderer_prelauncher_test.cc

Issue 2832153003: Move calling of shared browser test methods like SetUpOnMainThread/TearDownOnMainThread/RunTestOn... (Closed)
Patch Set: fixes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/renderer_prelauncher_test.cc
diff --git a/chromecast/browser/renderer_prelauncher_test.cc b/chromecast/browser/renderer_prelauncher_test.cc
index 3e36800cd46fcdcc6010d65afd0e89131fc212b8..81814a6edaddb4d0d532e48aec9c0ccf2e7ce1e6 100644
--- a/chromecast/browser/renderer_prelauncher_test.cc
+++ b/chromecast/browser/renderer_prelauncher_test.cc
@@ -30,7 +30,8 @@ class RendererPrelauncherTest : public content::BrowserTestBase {
protected:
// content::BrowserTestBase implementation:
void SetUp() override;
- void RunTestOnMainThreadLoop() override;
+ void PreRunTestOnMainThread() override;
+ void PostRunTestOnMainThread() override {}
private:
DISALLOW_COPY_AND_ASSIGN(RendererPrelauncherTest);
@@ -40,19 +41,13 @@ void RendererPrelauncherTest::SetUp() {
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
command_line->AppendSwitch(switches::kNoWifi);
command_line->AppendSwitchASCII(switches::kTestType, "browser");
-
- BrowserTestBase::SetUp();
}
-void RendererPrelauncherTest::RunTestOnMainThreadLoop() {
+void RendererPrelauncherTest::PreRunTestOnMainThread() {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
base::RunLoop().RunUntilIdle();
metrics::CastMetricsHelper::GetInstance()->SetDummySessionIdForTesting();
-
- SetUpOnMainThread();
- RunTestOnMainThread();
- TearDownOnMainThread();
}
IN_PROC_BROWSER_TEST_F(RendererPrelauncherTest, ReusedRenderer) {

Powered by Google App Engine
This is Rietveld 408576698