Ensure ime adapter gets connected to RWHVA

content/browser/android/render_widget_host_connector.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/render_widget_host_connector.h"
 
 #include "content/browser/frame_host/interstitial_page_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 
@@ skipping 109 matching lines @@
                ->GetRenderViewHost()
                ->GetWidget()
                ->GetView();
   }
   return static_cast<RenderWidgetHostViewAndroid*>(rwhv);
 }
 
 RenderWidgetHostConnector::RenderWidgetHostConnector(WebContents* web_contents)
     : render_widget_observer_(new Observer(web_contents, this)) {}
 
+void RenderWidgetHostConnector::Initialize() {
+  render_widget_observer_->RenderViewReady();

[boliu, 2017/04/21 16:20:02]

what it does is correct, but the RenderViewReady call makes no sense. you have
to actually check it is ready before you fake the signal

[Jinsuk Kim, 2017/04/21 16:30:04]

It would be like this:
auto* rwhva = GetRenderWidgetViewAndroid();
if (rwhva)
  UpdateRenderWidgetHostView(rwhva);

But then |if| is kind of not necessary because if it is null, the call will be
just no-op. Choose to just use RenderViewReady. Do you see it done without using
it?

[boliu, 2017/04/21 16:33:39]

Is that in RenderViewReady or in initialize? It should be correct to add a
DCHECK that GetRenderWidgetViewAndroid is non-null in RVReady, instead of the
runtime check.

If it's in Initialize, then yeah, just call UpdateRenderWidgetHostView without
the null check.

[Jinsuk Kim, 2017/04/21 16:53:16]

Inititialize(). Done.

+}
+
 RenderWidgetHostConnector::~RenderWidgetHostConnector() {}
 
 RenderWidgetHostViewAndroid* RenderWidgetHostConnector::GetRWHVAForTesting()
     const {
   return render_widget_observer_->active_rwhva();
 }
 
 }  // namespace content