Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 28321: [chromium-reviews] Rebaseline an SVG layout test (Closed)

Created:
11 years, 9 months ago by sidchat (Google)
Modified:
9 years, 7 months ago
Reviewers:
Finnur
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Rebaseline an SVG layout test. The difference is that we draw two additional one-pixel-wide black lines, one horizontal and one vertical, which occur on the top and left of the box respectively. This gives the box a 3-D appearance. After reviewing the SVG code, it seems we are doing the right thing; i.e., the code specifies to draw these lines with stroke-width="1" to give the 3-D appearance. I am thinking that in the original mac baseline, these lines are not prominent due to difference in Skia SVG line handling and shading. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10728

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages

Total messages: 4 (0 generated)
sidchat (Google)
11 years, 9 months ago (2009-03-02 19:32:57 UTC) #1
Finnur
http://codereview.chromium.org/28321/diff/1/2 File webkit/tools/layout_tests/test_lists/tests_fixable.txt (right): http://codereview.chromium.org/28321/diff/1/2#newcode63 Line 63: // Can defer this test once the crash ...
11 years, 9 months ago (2009-03-02 20:26:17 UTC) #2
sidchat (Google)
OK - new patch with updated tests_fixable.txt. Please have a look again. -Sid On 2009/03/02 ...
11 years, 9 months ago (2009-03-02 20:36:59 UTC) #3
Finnur
11 years, 9 months ago (2009-03-02 20:53:57 UTC) #4
OK

Powered by Google App Engine
This is Rietveld 408576698