Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 2832083002: dart2js: strengthen loop condition in loop body (Closed)

Created:
3 years, 8 months ago by sra1
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: strengthen loop condition in loop body Just a few improvements in a huge app, e.g. for (; node != null;) if (node == null ? element == null : node === element) return true; else node = node.parentElement; ---> for (; node != null;) if (node === element) return true; else node = node.parentElement; R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/64ab012f2a77b2709c250bacc9246b5c3949896c

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pkg/compiler/lib/src/ssa/optimize.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
3 years, 7 months ago (2017-04-28 02:15:25 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-04-28 22:17:13 UTC) #3
sra1
3 years, 7 months ago (2017-04-28 23:19:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
64ab012f2a77b2709c250bacc9246b5c3949896c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698