third_party/WebKit/Source/core/html/HTMLSelectElement.cpp - Issue 2832073003: Send mouse events for disabled form controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2832073003: Send mouse events for disabled form controls. (Closed)

Patch Set: Fix nits Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

index 7e64174696809ed278f35d08894a66d02bb80d36..d843d29162b0f2941283580ddfb6218e1a5e8c40 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

@@ -1495,7 +1495,7 @@ void HTMLSelectElement::ListBoxDefaultEventHandler(Event* event) {

// Convert to coords relative to the list box if needed.

MouseEvent* mouse_event = ToMouseEvent(event);

if (HTMLOptionElement* option = EventTargetOption(*mouse_event)) {

- if (!IsDisabledFormControl()) {

+ if (!option->IsDisabledFormControl()) {

#if OS(MACOSX)

UpdateSelectedState(option, mouse_event->metaKey(),

mouse_event->shiftKey());