Send mouse events for disabled form controls.

third_party/WebKit/Source/core/events/MouseEvent.cpp

 /*
  * Copyright (C) 2001 Peter Kelly (pmk@post.com)
  * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de)
  * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2003, 2005, 2006, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 421 matching lines @@
 MouseEvent& MouseEventDispatchMediator::Event() const {
   return ToMouseEvent(EventDispatchMediator::GetEvent());
 }
 
 DispatchEventResult MouseEventDispatchMediator::DispatchEvent(
     EventDispatcher& dispatcher) const {
   MouseEvent& mouse_event = Event();
   mouse_event.GetEventPath().AdjustForRelatedTarget(
       dispatcher.GetNode(), mouse_event.relatedTarget());
 
+  bool is_click = mouse_event.type() == EventTypeNames::click;
+  bool send_to_disabled_forms =

[jbroman, 2017/04/24 18:19:49]

super-nit: send_to_disabled_controls or something like that? This made me think
it applied to forms as a whole being disabled.

[dtapuska, 2017/04/24 19:14:39]

Done.

+      RuntimeEnabledFeatures::sendMouseEventsDisabledFormControlsEnabled();
+
+  if (send_to_disabled_forms && is_click &&
+      mouse_event.GetEventPath().DisabledFormControlExistsInPath()) {
+    return DispatchEventResult::kCanceledBeforeDispatch;
+  }
+
   if (!mouse_event.isTrusted())

[jbroman, 2017/04/24 18:19:49]

Does the layout test cover the logic beyond this point? It was my understanding
that "new MouseEvent" creates a non-trusted event.

[dtapuska, 2017/04/24 19:14:39]

Yes that is correct. But the changed logic is *before* this conditional. The
logic *after* this event check is the legacy path.

     return dispatcher.Dispatch();
 
-  if (IsDisabledFormControl(&dispatcher.GetNode()))
+  if (!send_to_disabled_forms && IsDisabledFormControl(&dispatcher.GetNode()))
     return DispatchEventResult::kCanceledBeforeDispatch;
 
   if (mouse_event.type().IsEmpty())
     return DispatchEventResult::kNotCanceled;  // Shouldn't happen.
 
   DCHECK(!mouse_event.target() ||
          mouse_event.target() != mouse_event.relatedTarget());
 
   EventTarget* related_target = mouse_event.relatedTarget();
 
   DispatchEventResult dispatch_result = dispatcher.Dispatch();
 
-  if (mouse_event.type() != EventTypeNames::click || mouse_event.detail() != 2)
+  if (!is_click || mouse_event.detail() != 2)
     return dispatch_result;
 
   // Special case: If it's a double click event, we also send the dblclick
   // event. This is not part of the DOM specs, but is used for compatibility
   // with the ondblclick="" attribute. This is treated as a separate event in
   // other DOM-compliant browsers like Firefox, and so we do the same.
   MouseEvent* double_click_event = MouseEvent::Create();
   double_click_event->InitMouseEventInternal(
       EventTypeNames::dblclick, mouse_event.bubbles(), mouse_event.cancelable(),
       mouse_event.view(), mouse_event.detail(), mouse_event.screenX(),
@@ skipping 106 matching lines @@
 
 int MouseEvent::offsetY() {
   if (!HasPosition())
     return 0;
   if (!has_cached_relative_position_)
     ComputeRelativePosition();
   return std::round(offset_location_.Y());
 }
 
 }  // namespace blink