Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4773)

Unified Diff: chrome/installer/mac/sign_installer_tools.sh

Issue 2832073002: Refactor mac signing scripts for development workflow (Closed)
Patch Set: Refactor mac signing scripts for development workflow Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mac/sign_installer_tools.sh
diff --git a/chrome/installer/mac/sign_installer_tools.sh b/chrome/installer/mac/sign_installer_tools.sh
index 4b0834d466465ec62d39af88452d03c4504859b6..2f2d6e848d905b918eb0d8cbbc2720f1f8e59a19 100755
--- a/chrome/installer/mac/sign_installer_tools.sh
+++ b/chrome/installer/mac/sign_installer_tools.sh
@@ -31,7 +31,8 @@ packaging_dir="${1}"
codesign_keychain="${2}"
codesign_id="${3}"
-enforcement_flags="restrict,library-validation,kill"
+script_dir="$(dirname "${0}")"
+source "${script_dir}/variables.sh"
executables=(goobspatch xzdec)
libraries=(liblzma_decompress.dylib)
@@ -42,7 +43,7 @@ for executable in "${executables[@]}"; do
everything+=("${sign_path}")
codesign --sign "${codesign_id}" --keychain "${codesign_keychain}" \
- "${sign_path}" --options "${enforcement_flags}"
+ "${sign_path}" --options "${enforcement_flags_tools}"
Mark Mentovai 2017/04/25 02:02:24 No custom requirement action here? Now that the re
Mark Mentovai 2017/04/25 02:02:25 enforcement_flags_installer_tools? “tools” is a li
Greg K 2017/04/25 18:45:21 Done.
done
for library in "${libraries[@]}"; do

Powered by Google App Engine
This is Rietveld 408576698