chrome/installer/mac/variables.sh - Issue 2832073002: Refactor mac signing scripts for development workflow

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/variables.sh

Issue 2832073002: Refactor mac signing scripts for development workflow (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 enforcement_flags_app="restrict"

	6 enforcement_flags_helpers="${enforcement_flags_app},library"

	7

	8 requirement_suffix="and certificate leaf=H\"605852E8A609E39F8CF795E396657D26B3A0 31BC\""
	Mark Mentovai 2017/04/24 15:00:23 What you upload and submit for review should only What you upload and submit for review should only ever show what you want to check in (unless you’ve clearly marked something “not for checkin”). This certainly isn’t suitable for checkin. Let’s say that I was a terrible reviewer who stamped this without scrutinizing it, and you got excited so you ticked the commit checkbox, because it’s been a long weekend and you forgot that you had left this development stuff behind. It lands in the tree, and official signing starts failing. Oh no! Greg K 2017/04/25 00:55:01 Acknowledged. Show quoted text On 2017/04/24 15:00:23, Mark Mentovai wrote: > What you upload and submit for review should only ever show what you want to > check in (unless you’ve clearly marked something “not for checkin”). This > certainly isn’t suitable for checkin. > > Let’s say that I was a terrible reviewer who stamped this without scrutinizing > it, and you got excited so you ticked the commit checkbox, because it’s been a > long weekend and you forgot that you had left this development stuff behind. It > lands in the tree, and official signing starts failing. Oh no! Acknowledged.
	9 #requirement_suffix="\

	10 #and (certificate leaf = H\"85cee8254216185620ddc8851c7a9fc4dfe120ef\" or \

	11 #certificate leaf = H\"c9a99324ca3fcb23dbcc36bd5fd4f9753305130a\") \

	12 #"
	Mark Mentovai 2017/04/24 15:00:23 We also have sign_installer_tools.sh. Should it ge We also have sign_installer_tools.sh. Should it get in on the action? Greg K 2017/04/25 00:55:01 Done. Show quoted text On 2017/04/24 15:00:23, Mark Mentovai wrote: > We also have sign_installer_tools.sh. Should it get in on the action? Done.
OLD	NEW

« chrome/installer/mac/sign_app.sh.in ('K') | « chrome/installer/mac/sign_versioned_dir.sh.in ('k') | no next file » | no next file with comments »