Chromium Code Reviews
Help | Chromium Project | Sign in
(368)

Issue 2832066: Marking TopSitesTest.DeleteNotifications as DISABLED (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by dhollowa
Modified:
4 years ago
CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Marking TopSitesTest.DeleteNotifications as DISABLED Marks TopSitesTest.DeleteNotifications as DISABLED. This test has been crashing unit_tests Mac 10.6. E.g. http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Tests/builds/5065/steps/unit_tests/logs/DeleteNotifications BUG=49799 TEST=TopSitesTest.DeleteNotifications TBR=nshkrob@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53208

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changing comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/history/top_sites_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
dhollowa
4 years, 10 months ago (2010-07-21 17:35:25 UTC) #1
Paweł Hajdan Jr.
LGTM with a comment. http://codereview.chromium.org/2832066/diff/1/2 File chrome/browser/history/top_sites_unittest.cc (right): http://codereview.chromium.org/2832066/diff/1/2#newcode708 chrome/browser/history/top_sites_unittest.cc:708: // This test has been ...
4 years, 10 months ago (2010-07-21 17:36:19 UTC) #2
Nik Shkrob
LGTM. I'll look into fixing this. On 2010/07/21 17:36:19, Paweł Hajdan Jr. wrote: > LGTM ...
4 years, 10 months ago (2010-07-21 17:38:20 UTC) #3
dhollowa
4 years, 10 months ago (2010-07-21 17:39:22 UTC) #4
http://codereview.chromium.org/2832066/diff/1/2
File chrome/browser/history/top_sites_unittest.cc (right):

http://codereview.chromium.org/2832066/diff/1/2#newcode708
chrome/browser/history/top_sites_unittest.cc:708: // This test has been failing
to complete on Mac 10.6 sporadically.
On 2010/07/21 17:36:19, Paweł Hajdan Jr. wrote:
> nit: Just say it crashes entire unit_tests, it indicates the severity of the
> problem more accurately.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be