Add some plumbing for in-progress work on enabling SSL proxy support....

Add some plumbing for in-progress work on enabling SSL proxy support.

BUG=29625
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53061

[tfarina, 2010-07-19 21:00:10]

http://codereview.chromium.org/2832057/diff/5001/6001
File net/proxy/proxy_info.h (right):

http://codereview.chromium.org/2832057/diff/5001/6001#newcode53
net/proxy/proxy_info.h:53: // Returns true if the first valid proxy server is a
http proxy.
nit: is a http -> is a https?

http://codereview.chromium.org/2832057/diff/5001/6001#newcode60
net/proxy/proxy_info.h:60: // Returns true if the first valid proxy server is a
https proxy.
nit: is a https -> is a http?

http://codereview.chromium.org/2832057/diff/5001/6003
File net/proxy/proxy_server.h (right):

http://codereview.chromium.org/2832057/diff/5001/6003#newcode32
net/proxy/proxy_server.h:32: SCHEME_HTTPS  = 1 << 5,
nit: align the equal with the others below (just to make it pretty)?

[eroman, 2010-07-19 21:47:38]

lgtm after addressing tfarina's nits, and also please describe what an HTTPS
proxy is by linking to some documentation/design page, as this is not something
standard.

[Mike Belshe, 2010-07-19 22:43:14]

http://codereview.chromium.org/2832057/diff/5001/6001
File net/proxy/proxy_info.h (right):

http://codereview.chromium.org/2832057/diff/5001/6001#newcode53
net/proxy/proxy_info.h:53: // Returns true if the first valid proxy server is a
http proxy.
On 2010/07/19 21:00:10, tfarina wrote:
> nit: is a http -> is a https?

Done.

http://codereview.chromium.org/2832057/diff/5001/6001#newcode60
net/proxy/proxy_info.h:60: // Returns true if the first valid proxy server is a
https proxy.
On 2010/07/19 21:00:10, tfarina wrote:
> nit: is a https -> is a http?

Done.

http://codereview.chromium.org/2832057/diff/5001/6003
File net/proxy/proxy_server.h (right):

http://codereview.chromium.org/2832057/diff/5001/6003#newcode32
net/proxy/proxy_server.h:32: SCHEME_HTTPS  = 1 << 5,
On 2010/07/19 21:00:10, tfarina wrote:
> nit: align the equal with the others below (just to make it pretty)?

Done.

[Mike Belshe, 2010-07-19 22:44:13]

Design doc added here: http://dev.chromium.org/spdy/spdy-proxy

Ryan will be updating further.

[eroman, 2010-07-19 22:58:10]

http://codereview.chromium.org/2832057/diff/4006/19001
File net/proxy/proxy_info.h (right):

http://codereview.chromium.org/2832057/diff/4006/19001#newcode53
net/proxy/proxy_info.h:53: // Returns true if the first valid proxy server is an
http proxy.
per tfarina's earlier comment: "http" --> "https"

http://codereview.chromium.org/2832057/diff/4006/19001#newcode60
net/proxy/proxy_info.h:60: // Returns true if the first valid proxy server is an
https proxy.
per tfarina's earlier comment: "https" --> "http"

[rch (use chromium not google), 2010-07-20 16:29:22]

On 2010/07/19 22:44:13, Mike Belshe wrote:
> Design doc added here: http://dev.chromium.org/spdy/spdy-proxy
> 
> Ryan will be updating further.

I made two small changes.  Looks great otherwise!