Issue 2832049: AutoFill auxiliary profiles should be off on non-Mac platforms.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2832049: AutoFill auxiliary profiles should be off on non-Mac platforms. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by dhollowa

Modified:
4 years ago

Reviewers:
Nico

CC:
chromium-reviews, ben+cc_chromium.org

Visibility:
Public.

Description

AutoFill auxiliary profiles should be off on non-Mac platforms. These changes conditionally turn off auxiliary profiles at compile time for non-Mac platforms. BUG=48217 TEST=Manual test on Windows: Surf to a form and trigger AutoFill suggestions. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51586

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	chrome/browser/autofill/autofill_manager.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	chrome/browser/autofill/personal_data_manager.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Trybot results:

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

LG I guess, but it would be cool if you could file a bug for ...

4 years, 11 months ago (2010-07-03 01:28:14 UTC) #1

dhollowa

4 years, 11 months ago (2010-07-03 02:19:02 UTC) #2

On 2010/07/03 01:28:14, Nico wrote:
> LG I guess, but it would be cool if you could file a bug for this, explain
what
> the problem is in there, and put it in the BUG= line.
> 
> Just in case I need to find out why this was added 6 months from now :-)

Done.

Expand Messages | Collapse Messages