Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2831933003: Use generated copy and compare for OriginalDisplay in ComputedStyle. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index e36db7e577e543ae6023ccefd8b855df28555781..b222b4f2a2df73a515b9d9e35601b80403fbe0ad 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -344,7 +344,6 @@ void ComputedStyle::CopyNonInheritedFromCached(const ComputedStyle& other) {
// See comments for each skipped flag below.
// These are not generated in ComputedStyleBase
- SetOriginalDisplay(other.OriginalDisplay());
SetVerticalAlign(other.VerticalAlign());
SetHasViewportUnits(other.HasViewportUnits());
SetHasRemUnitsInternal(other.HasRemUnits());
@@ -478,8 +477,6 @@ bool ComputedStyle::LoadingCustomFontsEqual(const ComputedStyle& other) const {
bool ComputedStyle::NonInheritedEqual(const ComputedStyle& other) const {
// compare everything except the pseudoStyle pointer
return ComputedStyleBase::NonInheritedEqual(other) &&
- OriginalDisplay() ==
- other.OriginalDisplay() && // Not generated in ComputedStyleBase
VerticalAlign() == other.VerticalAlign() && // Not generated in
// ComputedStyleBase
box_ == other.box_ &&
« no previous file with comments | « third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698