Make sure PointerEvents's isPrimary set correctly for stylus

third_party/WebKit/Source/core/input/PointerEventManager.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/input/PointerEventManager.h"
 
 #include "core/dom/DocumentUserGestureToken.h"
 #include "core/dom/ElementTraversal.h"
 #include "core/dom/shadow/FlatTreeTraversal.h"
 #include "core/events/MouseEvent.h"
@@ skipping 142 matching lines @@
     EventTarget* target_under_pointer =
         node_under_pointer_.at(pointer_id).target;
     if (target_under_pointer == target) {
       node_under_pointer_.Set(
           pointer_id,
           EventTargetAttributes(target_under_pointer,
                                 event_type == EventTypeNames::pointerover));
     }
   }
 
+  if (event_type == EventTypeNames::pointerleave)

[dtapuska, 2017/04/20 21:04:14]

Do you want to do this after the pointerleave is dispatched? So that if anything
queries states that it is correct while the leave is being dispatched?

[Navid Zolghadr, 2017/04/20 21:34:20]

I don't think doing this here is correct. This would remove the pointer
regardless of the type of the event. So if we send a pointerleave to an element
while mouse/pen/tuoch is leaving boundaries of an element inside the page they
will get removed from our data structures.

+    RemovePointer(pointer_event);
+
   if (!RuntimeEnabledFeatures::pointerEventEnabled())
     return WebInputEventResult::kNotHandled;
   if (!check_for_listener || target->HasEventListeners(event_type)) {
     UseCounter::Count(frame_, UseCounter::kPointerEventDispatch);
     if (event_type == EventTypeNames::pointerdown)
       UseCounter::Count(frame_, UseCounter::kPointerEventDispatchPointerDown);
 
     DCHECK(!dispatching_pointer_id_);
     AutoReset<int> dispatch_holder(&dispatching_pointer_id_, pointer_id);
     DispatchEventResult dispatch_result = target->DispatchEvent(pointer_event);
@@ skipping 538 matching lines @@
     if (first_id > unique_touch_event_id)
       return false;
     touch_ids_for_canceled_pointerdowns_.TakeFirst();
     if (first_id == unique_touch_event_id)
       return true;
   }
   return false;
 }
 
 }  // namespace blink