Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2272)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/task_scheduler/sequence.cc

Issue 2831883003: Do not inherit TaskPriority in TaskTraits. (Closed)
Patch Set: self-review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/task_scheduler/post_task.cc ('K') | « base/task_scheduler/scheduler_worker_unittest.cc ('k') | base/task_scheduler/sequence_unittest.cc » ('j') | base/task_scheduler/test_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/sequence.cc
diff --git a/base/task_scheduler/sequence.cc b/base/task_scheduler/sequence.cc
index 4db5478fe4a82e7893d047b1e53fa8906c93eb32..19d8ddf0d50fd832404c561c7db7994e5d25be76 100644
--- a/base/task_scheduler/sequence.cc
+++ b/base/task_scheduler/sequence.cc
@@ -16,6 +16,8 @@ Sequence::Sequence() = default;
bool Sequence::PushTask(std::unique_ptr<Task> task) {
DCHECK(task);
+ DCHECK_LT(static_cast<size_t>(task->traits.priority()),
+ arraysize(num_tasks_per_priority_));
// Use CHECK instead of DCHECK to crash earlier. See http://crbug.com/711167
// for details.
« base/task_scheduler/post_task.cc ('K') | « base/task_scheduler/scheduler_worker_unittest.cc ('k') | base/task_scheduler/sequence_unittest.cc » ('j') | base/task_scheduler/test_utils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698