Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Side by Side Diff: base/task_scheduler/sequence.cc

Issue 2831883003: Do not inherit TaskPriority in TaskTraits. (Closed)
Patch Set: self-review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/sequence.h" 5 #include "base/task_scheduler/sequence.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
11 11
12 namespace base { 12 namespace base {
13 namespace internal { 13 namespace internal {
14 14
15 Sequence::Sequence() = default; 15 Sequence::Sequence() = default;
16 16
17 bool Sequence::PushTask(std::unique_ptr<Task> task) { 17 bool Sequence::PushTask(std::unique_ptr<Task> task) {
18 DCHECK(task); 18 DCHECK(task);
19 DCHECK_LT(static_cast<size_t>(task->traits.priority()),
20 arraysize(num_tasks_per_priority_));
19 21
20 // Use CHECK instead of DCHECK to crash earlier. See http://crbug.com/711167 22 // Use CHECK instead of DCHECK to crash earlier. See http://crbug.com/711167
21 // for details. 23 // for details.
22 CHECK(task->task); 24 CHECK(task->task);
23 DCHECK(task->sequenced_time.is_null()); 25 DCHECK(task->sequenced_time.is_null());
24 task->sequenced_time = base::TimeTicks::Now(); 26 task->sequenced_time = base::TimeTicks::Now();
25 27
26 AutoSchedulerLock auto_lock(lock_); 28 AutoSchedulerLock auto_lock(lock_);
27 ++num_tasks_per_priority_[static_cast<int>(task->traits.priority())]; 29 ++num_tasks_per_priority_[static_cast<int>(task->traits.priority())];
28 queue_.push(std::move(task)); 30 queue_.push(std::move(task));
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 next_task_sequenced_time = queue_.front()->sequenced_time; 83 next_task_sequenced_time = queue_.front()->sequenced_time;
82 } 84 }
83 85
84 return SequenceSortKey(priority, next_task_sequenced_time); 86 return SequenceSortKey(priority, next_task_sequenced_time);
85 } 87 }
86 88
87 Sequence::~Sequence() = default; 89 Sequence::~Sequence() = default;
88 90
89 } // namespace internal 91 } // namespace internal
90 } // namespace base 92 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698