third_party/WebKit/Source/core/exported/BUILD.gn - Issue 2831833002: Move WebAssociatedURLLoaderImpl.* from web/ -> core/export/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/exported/BUILD.gn

Issue 2831833002: Move WebAssociatedURLLoaderImpl.* from web/ -> core/export/. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2017 The Chromium Authors. All rights reserved.	1 # Copyright 2017 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 import("//third_party/WebKit/Source/core/core.gni")	4 import("//third_party/WebKit/Source/core/core.gni")

5	5

6 blink_core_sources("exported") {	6 blink_core_sources("exported") {

7 sources = [	7 sources = [

	8 "WebAssociatedURLLoaderImpl.cpp",

	9 "WebAssociatedURLLoaderImpl.h",
	haraken 2017/04/20 07:34:28 I'd prefer putting only .cpp implementation files I'd prefer putting only .cpp implementation files of public APIs in xxx/exported/. (platform/exported/ mostly follows the rule.) So can we probably move these files to core/loader/ or somewhere?
8 "WebBlob.cpp",	10 "WebBlob.cpp",

9 ]	11 ]

10 }	12 }

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/exported/WebAssociatedURLLoaderImpl.h » ('j') | no next file with comments »