third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp - Issue 2831733003: Fix blits from multisampled renderbuffers to alpha:false WebGL back buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 2831733003: Fix blits from multisampled renderbuffers to alpha:false WebGL back buffer. (Closed)

Patch Set: Preemptively rebased. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc ('k') | third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

index 880604236f71dca7df59c01e699660d47d749a92..7df00729ad0c9aa29059ba70df629bacde5f964b 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

@@ -426,6 +426,8 @@ void WebGL2RenderingContextBase::blitFramebuffer(GLint src_x0,

if (isContextLost())

return;

+ DrawingBuffer::ScopedRGBEmulationForBlitFramebuffer emulation(

+ GetDrawingBuffer());

ccameron 2017/04/20 03:38:19 This incurs a call to CGLTexImageIOSurface2D at ev

Ken Russell (switch to Gerrit) 2017/04/20 17:12:33 No, the RGB texture is cached inside the DrawingBu

ContextGL()->BlitFramebufferCHROMIUM(src_x0, src_y0, src_x1, src_y1, dst_x0,

dst_y0, dst_x1, dst_y1, mask, filter);

}