third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp - Issue 2831683003: Refactor to centralize code which decides whether ObjectPaintProperties are needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp

Issue 2831683003: Refactor to centralize code which decides whether ObjectPaintProperties are needed. (Closed)

Patch Set: none Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp ('k') | third_party/WebKit/Source/core/paint/RarePaintData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp

index 9fdb15784eac0ec38aeca66984bdacdcc310d5f1..8e6553f43080bbbe59fda3c84b186d866f47aa94 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp

@@ -552,7 +552,8 @@ TEST_P(PaintPropertyTreeUpdateTest,

// Removing the animation should remove the transform node.

target->removeAttribute(HTMLNames::classAttr);

GetDocument().View()->UpdateAllLifecyclePhases();

- EXPECT_EQ(nullptr, properties->Transform());

+ // Ensure the paint properties object was cleared as it is no longer needed.

+ EXPECT_EQ(nullptr, target->GetLayoutObject()->PaintProperties());

}

TEST_P(PaintPropertyTreeUpdateTest,

@@ -566,7 +567,7 @@ TEST_P(PaintPropertyTreeUpdateTest,

// Removing the animation should remove the effect node.

target->removeAttribute(HTMLNames::classAttr);

GetDocument().View()->UpdateAllLifecyclePhases();

- EXPECT_EQ(nullptr, properties->Effect());

+ EXPECT_EQ(nullptr, target->GetLayoutObject()->PaintProperties());

}

TEST_P(PaintPropertyTreeUpdateTest,