Refactor to centralize code which decides whether ObjectPaintProperties are needed.

third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/PaintPropertyTreeBuilderTest.h"
 
 #include "core/html/HTMLIFrameElement.h"
 #include "core/layout/LayoutTreeAsText.h"
 #include "core/paint/ObjectPaintProperties.h"
 #include "core/paint/PaintPropertyTreePrinter.h"
@@ skipping 360 matching lines @@
   EXPECT_FALSE(FrameScrollTranslation()->HasDirectCompositingReasons());
 
   CHECK_EXACT_VISUAL_RECT(LayoutRect(173, 556, 400, 300),
                           transform->GetLayoutObject(),
                           GetDocument().View()->GetLayoutView());
 
   transform->setAttribute(
       HTMLNames::styleAttr,
       "margin-left: 50px; margin-top: 100px; width: 400px; height: 300px;");
   GetDocument().View()->UpdateAllLifecyclePhases();
-  EXPECT_EQ(nullptr,
-            transform->GetLayoutObject()->PaintProperties()->Transform());
+  EXPECT_EQ(nullptr, transform->GetLayoutObject()->PaintProperties());
 
   transform->setAttribute(
       HTMLNames::styleAttr,
       "margin-left: 50px; margin-top: 100px; width: 400px; height: 300px; "
       "transform: translate3d(123px, 456px, 789px)");
   GetDocument().View()->UpdateAllLifecyclePhases();
   EXPECT_EQ(
       TransformationMatrix().Translate3d(123, 456, 789),
       transform->GetLayoutObject()->PaintProperties()->Transform()->Matrix());
 }
@@ skipping 79 matching lines @@
   EXPECT_TRUE(transform_properties->Transform()->HasDirectCompositingReasons());
 
   CHECK_EXACT_VISUAL_RECT(LayoutRect(50, 100, 400, 300),
                           transform->GetLayoutObject(),
                           GetDocument().View()->GetLayoutView());
 
   transform->setAttribute(
       HTMLNames::styleAttr,
       "margin-left: 50px; margin-top: 100px; width: 400px; height: 300px;");
   GetDocument().View()->UpdateAllLifecyclePhases();
-  EXPECT_EQ(nullptr,
-            transform->GetLayoutObject()->PaintProperties()->Transform());
+  EXPECT_EQ(nullptr, transform->GetLayoutObject()->PaintProperties());
 
   transform->setAttribute(
       HTMLNames::styleAttr,
       "margin-left: 50px; margin-top: 100px; width: 400px; height: 300px; "
       "will-change: transform");
   GetDocument().View()->UpdateAllLifecyclePhases();
   EXPECT_EQ(
       TransformationMatrix(),
       transform->GetLayoutObject()->PaintProperties()->Transform()->Matrix());
 }
@@ skipping 1442 matching lines @@
       "    <rect id='rect' transform='translate(1, 1)'/>"
       "</svg>");
 
   LayoutObject& svg_with_transform =
       *GetDocument().GetElementById("svg")->GetLayoutObject();
   const ObjectPaintProperties* svg_with_transform_properties =
       svg_with_transform.PaintProperties();
   EXPECT_EQ(TransformationMatrix(),
             svg_with_transform_properties->Transform()->Matrix());
   EXPECT_EQ(LayoutPoint(FloatPoint(0.1, 0)), svg_with_transform.PaintOffset());
-  EXPECT_EQ(nullptr,
-            svg_with_transform_properties->SvgLocalToBorderBoxTransform());
+  EXPECT_TRUE(svg_with_transform_properties->SvgLocalToBorderBoxTransform() ==
+              nullptr);
 
   LayoutObject& rect_with_transform =
       *GetDocument().GetElementById("rect")->GetLayoutObject();
   const ObjectPaintProperties* rect_with_transform_properties =
       rect_with_transform.PaintProperties();
   EXPECT_EQ(TransformationMatrix().Translate(1, 1),
             rect_with_transform_properties->Transform()->Matrix());
 
   // Ensure there is no PaintOffset transform between the rect and the svg's
   // transform.
@@ skipping 370 matching lines @@
 
   // Remove transform from b. B's transform node should be removed from the
   // tree, and a and c's transform nodes should be unchanged (with c's parent
   // adjusted).
   b->setAttribute(HTMLNames::styleAttr, "");
   GetDocument().View()->UpdateAllLifecyclePhases();
 
   EXPECT_EQ(a_properties, a->GetLayoutObject()->PaintProperties());
   EXPECT_EQ(a_transform_node, a_properties->Transform());
 
-  EXPECT_EQ(b_properties, b->GetLayoutObject()->PaintProperties());
-  EXPECT_EQ(nullptr, b_properties->Transform());
+  EXPECT_EQ(nullptr, b->GetLayoutObject()->PaintProperties());
 
   EXPECT_EQ(c_properties, c->GetLayoutObject()->PaintProperties());
   EXPECT_EQ(c_transform_node, c_properties->Transform());
   EXPECT_EQ(a_transform_node, c_transform_node->Parent());
 
   CHECK_EXACT_VISUAL_RECT(LayoutRect(33, 44, 50, 60), a->GetLayoutObject(),
                           frame_view->GetLayoutView());
   CHECK_EXACT_VISUAL_RECT(LayoutRect(33, 44, 50, 20), b->GetLayoutObject(),
                           frame_view->GetLayoutView());
   CHECK_EXACT_VISUAL_RECT(LayoutRect(110, 132, 10, 20), c->GetLayoutObject(),
                           frame_view->GetLayoutView());
 
   // Re-add transform to b. B's transform node should be inserted into the tree,
   // and a and c's transform nodes should be unchanged (with c's parent
   // adjusted).
   b->setAttribute(HTMLNames::styleAttr, "transform: translate(4px, 5px)");
   GetDocument().View()->UpdateAllLifecyclePhases();
 
   EXPECT_EQ(a_properties, a->GetLayoutObject()->PaintProperties());
   EXPECT_EQ(a_transform_node, a_properties->Transform());
 
+  b_properties = b->GetLayoutObject()->PaintProperties();
   EXPECT_EQ(b_properties, b->GetLayoutObject()->PaintProperties());
   b_transform_node = b_properties->Transform();
   EXPECT_EQ(TransformationMatrix().Translate(4, 5), b_transform_node->Matrix());
   EXPECT_EQ(a_transform_node, b_transform_node->Parent());
 
   EXPECT_EQ(c_properties, c->GetLayoutObject()->PaintProperties());
   EXPECT_EQ(c_transform_node, c_properties->Transform());
   EXPECT_EQ(b_transform_node, c_transform_node->Parent());
 
   CHECK_EXACT_VISUAL_RECT(LayoutRect(33, 44, 50, 60), a->GetLayoutObject(),
@@ skipping 638 matching lines @@
       "      <div id=absolute style='position: absolute'>absolute</div>"
       "    </div>"
       "  </span>"
       "</div>");
   // There should be anonymous block created containing the inline "relative",
   // serving as the container of "absolute".
   EXPECT_TRUE(
       GetLayoutObjectByElementId("absolute")->Container()->IsLayoutBlock());
 }
 
+TEST_P(PaintPropertyTreeBuilderTest, Reflection) {
+  SetBodyInnerHTML(
+      "<div id='filter' style='-webkit-box-reflect: below; height:1000px;'>"
+      "</div>");
+  const ObjectPaintProperties* filter_properties =
+      GetLayoutObjectByElementId("filter")->PaintProperties();
+  EXPECT_TRUE(filter_properties->Filter()->Parent()->IsRoot());
+  EXPECT_EQ(FrameScrollTranslation(),
+            filter_properties->Filter()->LocalTransformSpace());
+  EXPECT_EQ(FrameContentClip(), filter_properties->Filter()->OutputClip());
+}
+
 TEST_P(PaintPropertyTreeBuilderTest, SimpleFilter) {
   SetBodyInnerHTML(
       "<div id='filter' style='filter:opacity(0.5); height:1000px;'>"
       "</div>");
   const ObjectPaintProperties* filter_properties =
       GetLayoutObjectByElementId("filter")->PaintProperties();
   EXPECT_TRUE(filter_properties->Filter()->Parent()->IsRoot());
   EXPECT_EQ(FrameScrollTranslation(),
             filter_properties->Filter()->LocalTransformSpace());
   EXPECT_EQ(FrameContentClip(), filter_properties->Filter()->OutputClip());
@@ skipping 431 matching lines @@
 
   LayoutObject& svg_root =
       *GetDocument().GetElementById("svgroot")->GetLayoutObject();
   const ObjectPaintProperties* svg_root_properties = svg_root.PaintProperties();
   EXPECT_TRUE(svg_root_properties->Effect());
   EXPECT_EQ(EffectPaintPropertyNode::Root(),
             svg_root_properties->Effect()->Parent());
 }
 
 }  // namespace blink