Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2831683003: Refactor to centralize code which decides whether ObjectPaintProperties are needed. (Closed)
Patch Set: none Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2009 Google Inc. All rights reserved. 8 * Copyright (C) 2009 Google Inc. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1799 matching lines...) Expand 10 before | Expand all | Expand 10 after
1810 // The following non-const functions for ObjectPaintProperties should only 1810 // The following non-const functions for ObjectPaintProperties should only
1811 // be called from PaintPropertyTreeBuilder. 1811 // be called from PaintPropertyTreeBuilder.
1812 ObjectPaintProperties& EnsurePaintProperties() { 1812 ObjectPaintProperties& EnsurePaintProperties() {
1813 return layout_object_.EnsureRarePaintData().EnsurePaintProperties(); 1813 return layout_object_.EnsureRarePaintData().EnsurePaintProperties();
1814 } 1814 }
1815 ObjectPaintProperties* PaintProperties() { 1815 ObjectPaintProperties* PaintProperties() {
1816 if (auto* paint_data = layout_object_.GetRarePaintData()) 1816 if (auto* paint_data = layout_object_.GetRarePaintData())
1817 return paint_data->PaintProperties(); 1817 return paint_data->PaintProperties();
1818 return nullptr; 1818 return nullptr;
1819 } 1819 }
1820 void ClearPaintProperties() {
1821 if (auto* paint_data = layout_object_.GetRarePaintData())
1822 paint_data->ClearPaintProperties();
1823 }
1820 1824
1821 // The following non-const functions for local border box properties should 1825 // The following non-const functions for local border box properties should
1822 // only be called from PaintPropertyTreeBuilder. 1826 // only be called from PaintPropertyTreeBuilder.
1823 void ClearLocalBorderBoxProperties() { 1827 void ClearLocalBorderBoxProperties() {
1824 if (auto* paint_data = layout_object_.GetRarePaintData()) 1828 if (auto* paint_data = layout_object_.GetRarePaintData())
1825 paint_data->ClearLocalBorderBoxProperties(); 1829 paint_data->ClearLocalBorderBoxProperties();
1826 } 1830 }
1827 void SetLocalBorderBoxProperties(PropertyTreeState& local_border_box) { 1831 void SetLocalBorderBoxProperties(PropertyTreeState& local_border_box) {
1828 return layout_object_.EnsureRarePaintData().SetLocalBorderBoxProperties( 1832 return layout_object_.EnsureRarePaintData().SetLocalBorderBoxProperties(
1829 local_border_box); 1833 local_border_box);
(...skipping 993 matching lines...) Expand 10 before | Expand all | Expand 10 after
2823 CORE_EXPORT void showLineTree(const blink::LayoutObject*); 2827 CORE_EXPORT void showLineTree(const blink::LayoutObject*);
2824 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1); 2828 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1);
2825 // We don't make object2 an optional parameter so that showLayoutTree 2829 // We don't make object2 an optional parameter so that showLayoutTree
2826 // can be called from gdb easily. 2830 // can be called from gdb easily.
2827 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1, 2831 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1,
2828 const blink::LayoutObject* object2); 2832 const blink::LayoutObject* object2);
2829 2833
2830 #endif 2834 #endif
2831 2835
2832 #endif // LayoutObject_h 2836 #endif // LayoutObject_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698