third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h - Issue 2831683003: Refactor to centralize code which decides whether ObjectPaintProperties are needed.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h

Issue 2831683003: Refactor to centralize code which decides whether ObjectPaintProperties are needed. (Closed)

Patch Set: none Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.h ('k') | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef PaintPropertyTreeBuilder_h	5 #ifndef PaintPropertyTreeBuilder_h

6 #define PaintPropertyTreeBuilder_h	6 #define PaintPropertyTreeBuilder_h

7	7

8 #include "platform/geometry/LayoutPoint.h"	8 #include "platform/geometry/LayoutPoint.h"

9 #include "platform/graphics/paint/ClipPaintPropertyNode.h"	9 #include "platform/graphics/paint/ClipPaintPropertyNode.h"

10 #include "platform/graphics/paint/EffectPaintPropertyNode.h"	10 #include "platform/graphics/paint/EffectPaintPropertyNode.h"

(...skipping 143 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
154 PaintPropertyTreeBuilderContext&);	154 PaintPropertyTreeBuilderContext&);

155 ALWAYS_INLINE static void UpdateSvgLocalToBorderBoxTransform(	155 ALWAYS_INLINE static void UpdateSvgLocalToBorderBoxTransform(

156 const LayoutObject&,	156 const LayoutObject&,

157 PaintPropertyTreeBuilderContext&);	157 PaintPropertyTreeBuilderContext&);

158 ALWAYS_INLINE static void UpdateScrollAndScrollTranslation(	158 ALWAYS_INLINE static void UpdateScrollAndScrollTranslation(

159 const LayoutObject&,	159 const LayoutObject&,

160 PaintPropertyTreeBuilderContext&);	160 PaintPropertyTreeBuilderContext&);

161 ALWAYS_INLINE static void UpdateOutOfFlowContext(	161 ALWAYS_INLINE static void UpdateOutOfFlowContext(

162 const LayoutObject&,	162 const LayoutObject&,

163 PaintPropertyTreeBuilderContext&);	163 PaintPropertyTreeBuilderContext&);

	164

	165 ALWAYS_INLINE static void UpdatePaintProperties(const LayoutObject&);
	pdr. 2017/04/20 22:56:28 Can you add a comment here? Something like: // Ens Can you add a comment here? Something like: // Ensure the ObjectPaintProperties object is created if it will be needed, or cleared otherwise. chrishtr 2017/04/21 01:20:02 Done. Show quoted text On 2017/04/20 at 22:56:28, pdr. wrote: > Can you add a comment here? Something like: > // Ensure the ObjectPaintProperties object is created if it will be needed, or cleared otherwise. Done.
164 };	166 };

165	167

166 } // namespace blink	168 } // namespace blink

167	169

168 #endif // PaintPropertyTreeBuilder_h	170 #endif // PaintPropertyTreeBuilder_h

OLD	NEW