Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: content/browser/child_process_security_policy_unittest.cc

Issue 2831683002: Introduce support for origins that require process isolation. (Closed)
Patch Set: Charlie's comments (round 3) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/child_process_security_policy_unittest.cc
diff --git a/content/browser/child_process_security_policy_unittest.cc b/content/browser/child_process_security_policy_unittest.cc
index d0a347c996c4fba54c3a1bd64f23052715d51fa5..3da1c80538f613ad05326142e705106f36385bf4 100644
--- a/content/browser/child_process_security_policy_unittest.cc
+++ b/content/browser/child_process_security_policy_unittest.cc
@@ -893,4 +893,29 @@ TEST_F(ChildProcessSecurityPolicyTest, OriginGranting) {
p->Remove(kRendererID);
}
+// Verifies parsing logic that extracts origins from --isolate-origins.
+TEST_F(ChildProcessSecurityPolicyTest, IsolateOriginsFromCommandLine) {
+ // Invalid and unique origins are not permitted.
+ auto* policy = ChildProcessSecurityPolicyImpl::GetInstance();
+ policy->AddIsolatedOriginsFromCommandLine("foo");
+ policy->AddIsolatedOriginsFromCommandLine("");
+ policy->AddIsolatedOriginsFromCommandLine("about:blank");
+ EXPECT_EQ(0U, policy->isolated_origins_.size());
+
+ policy->AddIsolatedOriginsFromCommandLine("http://isolated.foo.com");
+ EXPECT_EQ(1U, policy->isolated_origins_.size());
+ EXPECT_TRUE(
+ policy->IsIsolatedOrigin(url::Origin(GURL("http://isolated.foo.com"))));
+
+ policy->AddIsolatedOriginsFromCommandLine(
+ "http://a.com,https://b.com,,https://c.com:8000");
+ EXPECT_EQ(4U, policy->isolated_origins_.size());
+ EXPECT_TRUE(
+ policy->IsIsolatedOrigin(url::Origin(GURL("http://isolated.foo.com"))));
+ EXPECT_TRUE(policy->IsIsolatedOrigin(url::Origin(GURL("http://a.com"))));
+ EXPECT_TRUE(policy->IsIsolatedOrigin(url::Origin(GURL("https://b.com"))));
+ EXPECT_TRUE(
+ policy->IsIsolatedOrigin(url::Origin(GURL("https://c.com:8000"))));
+}
+
} // namespace content
« no previous file with comments | « content/browser/child_process_security_policy_impl.cc ('k') | content/browser/isolated_origin_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698