Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 283163002: Attempt #3: Change Skia DEPS to pull from googlesource (git) (Closed)

Created:
6 years, 7 months ago by borenet
Modified:
6 years, 7 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Attempt #3: Change Skia DEPS to pull from googlesource (git) - Uploading from pure-svn and intending to commit manually to properly remove the directory from svn. - Includes deps_whitelist change for new Skia DEP R=iannucci@chromium.org, mkosiba@chromium.org, torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271262

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -48 lines) Patch
M DEPS View 1 3 chunks +3 lines, -11 lines 0 comments Download
M android_webview/buildbot/deps_whitelist.py View 1 1 chunk +1 line, -3 lines 0 comments Download
D third_party/skia/LICENSE View 1 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/skia/OWNERS View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/skia/README.chromium View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
borenet
My understanding is that android-infra will need to perform some action to make sure that ...
6 years, 7 months ago (2014-05-14 20:16:11 UTC) #1
iannucci
lgtm from my pov
6 years, 7 months ago (2014-05-14 22:25:27 UTC) #2
mkosiba (inactive)
LGTM for android_webview. Thanks!
6 years, 7 months ago (2014-05-15 10:25:22 UTC) #3
Torne
On 2014/05/14 20:16:11, borenet wrote: > My understanding is that android-infra will need to perform ...
6 years, 7 months ago (2014-05-15 10:31:58 UTC) #4
borenet
6 years, 7 months ago (2014-05-17 22:49:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r271262 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698