Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2275)

Unified Diff: ash/display/window_tree_host_manager.cc

Issue 2831583005: Enable Config::MUS to use classic IME instead of servicified IME. (Closed)
Patch Set: Addressed feedback. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/mus/ash_window_tree_host_mus.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/display/window_tree_host_manager.cc
diff --git a/ash/display/window_tree_host_manager.cc b/ash/display/window_tree_host_manager.cc
index bce98e78e056894aeb9fad3559837a808bcb5f3d..073be1f74457c2d1573a7bfeefb9fffca100bf14 100644
--- a/ash/display/window_tree_host_manager.cc
+++ b/ash/display/window_tree_host_manager.cc
@@ -823,21 +823,18 @@ AshWindowTreeHost* WindowTreeHostManager::AddWindowTreeHostForDisplay(
AshWindowTreeHost* ash_host =
AshWindowTreeHost::Create(params_with_bounds).release();
aura::WindowTreeHost* host = ash_host->AsWindowTreeHost();
- // TODO: Config::MUS should not install an InputMethod.
- // http://crbug.com/706913
- if (!host->has_input_method()) {
- if (!input_method_) { // Singleton input method instance for Ash.
- input_method_ = ui::CreateInputMethod(this, host->GetAcceleratedWidget());
- // Makes sure the input method is focused by default when created, because
- // Ash uses singleton InputMethod and it won't call OnFocus/OnBlur when
- // the active window changed.
- input_method_->OnFocus();
- input_method_event_handler_.reset(
- new InputMethodEventHandler(input_method_.get()));
- }
- host->SetSharedInputMethod(input_method_.get());
- ash_host->set_input_method_handler(input_method_event_handler_.get());
+ DCHECK(!host->has_input_method());
sky 2017/05/03 15:25:27 The plan is to use this code for both mash and mus
Hadi 2017/05/03 19:35:42 Done.
+ if (!input_method_) { // Singleton input method instance for Ash.
+ input_method_ = ui::CreateInputMethod(this, host->GetAcceleratedWidget());
+ // Makes sure the input method is focused by default when created, because
+ // Ash uses singleton InputMethod and it won't call OnFocus/OnBlur when
+ // the active window changed.
+ input_method_->OnFocus();
+ input_method_event_handler_.reset(
+ new InputMethodEventHandler(input_method_.get()));
}
+ host->SetSharedInputMethod(input_method_.get());
+ ash_host->set_input_method_handler(input_method_event_handler_.get());
host->window()->SetName(base::StringPrintf(
"%sRootWindow-%d", params_with_bounds.offscreen ? "Offscreen" : "",
« no previous file with comments | « no previous file | ash/mus/ash_window_tree_host_mus.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698