Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: components/plugins/renderer/webview_plugin.h

Issue 2831583004: Remove redundant WebLocalFrame* parameter from DidClearWindowObject (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/plugins/renderer/webview_plugin.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_ 5 #ifndef COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_
6 #define COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_ 6 #define COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_
7 7
8 #include <list> 8 #include <list>
9 #include <memory> 9 #include <memory>
10 10
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 const blink::WebImage&, 163 const blink::WebImage&,
164 const blink::WebPoint&) override; 164 const blink::WebPoint&) override;
165 // TODO(ojan): Remove this override and have this class use a non-null 165 // TODO(ojan): Remove this override and have this class use a non-null
166 // layerTreeView. 166 // layerTreeView.
167 bool AllowsBrokenNullLayerTreeView() const override; 167 bool AllowsBrokenNullLayerTreeView() const override;
168 void DidInvalidateRect(const blink::WebRect&) override; 168 void DidInvalidateRect(const blink::WebRect&) override;
169 void DidChangeCursor(const blink::WebCursorInfo& cursor) override; 169 void DidChangeCursor(const blink::WebCursorInfo& cursor) override;
170 void ScheduleAnimation() override; 170 void ScheduleAnimation() override;
171 171
172 // WebFrameClient methods: 172 // WebFrameClient methods:
173 void DidClearWindowObject(blink::WebLocalFrame* frame) override; 173 void DidClearWindowObject() override;
174 174
175 private: 175 private:
176 WebViewPlugin* plugin_; 176 WebViewPlugin* plugin_;
177 177
178 // Owned by us, deleted via |close()|. 178 // Owned by us, deleted via |close()|.
179 blink::WebView* web_view_; 179 blink::WebView* web_view_;
180 }; 180 };
181 WebViewHelper web_view_helper_; 181 WebViewHelper web_view_helper_;
182 182
183 // Should be invalidated when destroy() is called. 183 // Should be invalidated when destroy() is called.
184 base::WeakPtrFactory<WebViewPlugin> weak_factory_; 184 base::WeakPtrFactory<WebViewPlugin> weak_factory_;
185 }; 185 };
186 186
187 #endif // COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_ 187 #endif // COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_
OLDNEW
« no previous file with comments | « no previous file | components/plugins/renderer/webview_plugin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698