Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: third_party/WebKit/Source/core/editing/LayoutSelection.h

Issue 2831583003: Remove LayoutView from LayoutSelection::commit() (Closed)
Patch Set: update Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2006 Apple Computer, Inc. 3 * Copyright (C) 2006 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 11 matching lines...) Expand all
22 #ifndef LayoutSelection_h 22 #ifndef LayoutSelection_h
23 #define LayoutSelection_h 23 #define LayoutSelection_h
24 24
25 #include "core/editing/Position.h" 25 #include "core/editing/Position.h"
26 #include "core/editing/VisibleSelection.h" 26 #include "core/editing/VisibleSelection.h"
27 #include "platform/heap/Handle.h" 27 #include "platform/heap/Handle.h"
28 28
29 namespace blink { 29 namespace blink {
30 30
31 class FrameSelection; 31 class FrameSelection;
32 class LayoutView;
33 32
34 class LayoutSelection final : public GarbageCollected<LayoutSelection> { 33 class LayoutSelection final : public GarbageCollected<LayoutSelection> {
35 public: 34 public:
36 enum class PaintHint { kHide, kKeep, kPaint }; 35 enum class PaintHint { kHide, kKeep, kPaint };
37 36
38 static LayoutSelection* Create(FrameSelection& frame_selection) { 37 static LayoutSelection* Create(FrameSelection& frame_selection) {
39 return new LayoutSelection(frame_selection); 38 return new LayoutSelection(frame_selection);
40 } 39 }
41 40
42 bool HasPendingSelection() const { return has_pending_selection_; } 41 bool HasPendingSelection() const { return has_pending_selection_; }
43 void SetHasPendingSelection(PaintHint); 42 void SetHasPendingSelection(PaintHint);
44 void Commit(LayoutView&); 43 void Commit();
45 44
46 IntRect SelectionBounds(); 45 IntRect SelectionBounds();
47 void InvalidatePaintForSelection(); 46 void InvalidatePaintForSelection();
48 enum SelectionPaintInvalidationMode { 47 enum SelectionPaintInvalidationMode {
49 kPaintInvalidationNewXOROld, 48 kPaintInvalidationNewXOROld,
50 kPaintInvalidationNewMinusOld 49 kPaintInvalidationNewMinusOld
51 }; 50 };
52 void SetSelection( 51 void SetSelection(
53 LayoutObject* start, 52 LayoutObject* start,
54 int start_pos, 53 int start_pos,
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 // TODO(yosin): Clarify the meaning of these variables. editing/ passes 88 // TODO(yosin): Clarify the meaning of these variables. editing/ passes
90 // them as offsets in the DOM tree but layout uses them as offset in the 89 // them as offsets in the DOM tree but layout uses them as offset in the
91 // layout tree. 90 // layout tree.
92 int selection_start_pos_; 91 int selection_start_pos_;
93 int selection_end_pos_; 92 int selection_end_pos_;
94 }; 93 };
95 94
96 } // namespace blink 95 } // namespace blink
97 96
98 #endif 97 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.cpp ('k') | third_party/WebKit/Source/core/editing/LayoutSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698