dart2js: --fast-startup: cache prototypes in local in tear-off setup

dart2js: --fast-startup: cache prototypes in local in tear-off setup

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/7dbd34d9a4c48818c9c98de3a572ac0d5a4b9633

[sra1, 2017-04-21 22:10:11]

Patchset #2 (id:20001) has been deleted

[sra1, 2017-04-21 22:10:17]

Patchset #1 (id:1) has been deleted

[sra1, 2017-04-21 22:11:08]

sra@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2017-04-24 13:21:20]

LGTM.

https://codereview.chromium.org/2831493003/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/2831493003/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:1040: ///
Wraps the statement in a named function to that it shows up as a unit in
so that

https://codereview.chromium.org/2831493003/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:1075:
container = temp;
Add a comment here, and/or at "container = ...".
The whole thing is a bit too clever without comments.

There are two things that are not obvious:
1. line 1071 is not yet added to the code. That is, at first "use", the temp is
assigned.
2. `container = temp` only matters if there is more than one method, in which
case `temp` is defined. Otherwise, it's just null.

[sra1, 2017-04-25 00:02:19]

https://codereview.chromium.org/2831493003/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/2831493003/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:1075:
container = temp;
On 2017/04/24 13:21:20, floitsch wrote:
> Add a comment here, and/or at "container = ...".
> The whole thing is a bit too clever without comments.
> 
> There are two things that are not obvious:
> 1. line 1071 is not yet added to the code. That is, at first "use", the temp
is
> assigned.
> 2. `container = temp` only matters if there is more than one method, in which
> case `temp` is defined. Otherwise, it's just null.

Done.

[sra1, 2017-04-25 03:39:19]

Description was changed from

==========
dart2js: --fast-startup: cache prototypes in local in tear-off setup
==========

to

==========
dart2js: --fast-startup: cache prototypes in local in tear-off setup

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7dbd34d9a4c48818c9c98de3a572ac0d5a4b9633
==========

[sra1, 2017-04-25 03:39:20]

Committed patchset #2 (id:60001) manually as
7dbd34d9a4c48818c9c98de3a572ac0d5a4b9633 (presubmit successful).