Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: extensions/renderer/api_binding_hooks_delegate.h

Issue 2831453002: [Extensions Bindings] Move custom handling to APIBindingHooksDelegate (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_binding_hooks.cc ('k') | extensions/renderer/api_binding_hooks_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_binding_hooks_delegate.h
diff --git a/extensions/renderer/api_binding_hooks_delegate.h b/extensions/renderer/api_binding_hooks_delegate.h
index 2fa84b8f160ddd3666435237026ed238856c99f4..51f3e77b3d63e3f142a22490875e4cc8848662c0 100644
--- a/extensions/renderer/api_binding_hooks_delegate.h
+++ b/extensions/renderer/api_binding_hooks_delegate.h
@@ -5,6 +5,7 @@
#ifndef EXTENSIONS_RENDERER_API_BINDING_HOOKS_DELEGATE_H_
#define EXTENSIONS_RENDERER_API_BINDING_HOOKS_DELEGATE_H_
+#include "extensions/renderer/api_binding_hooks.h"
#include "extensions/renderer/api_binding_types.h"
#include "v8/include/v8.h"
@@ -23,7 +24,13 @@ class APIBindingHooksDelegate {
const std::string& event_name,
v8::Local<v8::Value>* event_out);
- // TODO(devlin): Add a virtual HandleRequest() method.
+ // Allows custom implementations to handle a given request.
+ virtual APIBindingHooks::RequestResult HandleRequest(
+ const std::string& method_name,
+ const APISignature* signature,
+ v8::Local<v8::Context> context,
+ std::vector<v8::Local<v8::Value>>* arguments,
+ const APITypeReferenceMap& refs);
};
} // namespace extensions
« no previous file with comments | « extensions/renderer/api_binding_hooks.cc ('k') | extensions/renderer/api_binding_hooks_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698