chrome/browser/win/jumplist_updater.cc - Issue 2831433003: Time out jumplist update for very slow or busy OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/win/jumplist_updater.cc

Issue 2831433003: Time out jumplist update for very slow or busy OS (Closed)

Patch Set: Address comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/win/jumplist_updater.cc

diff --git a/chrome/browser/win/jumplist_updater.cc b/chrome/browser/win/jumplist_updater.cc

index 4265de1163585780f4e92e68c2a78a10b629006d..7ceef5f5ca9ea893da951cc31f7694d4aac80925 100644

--- a/chrome/browser/win/jumplist_updater.cc

+++ b/chrome/browser/win/jumplist_updater.cc

@@ -110,7 +110,6 @@ JumpListUpdater::~JumpListUpdater() {

// static

bool JumpListUpdater::IsEnabled() {

- // JumpList is implemented only on Windows 7 or later.

// Do not create custom JumpLists in tests. See http://crbug.com/389375.

return base::win::GetVersion() >= base::win::VERSION_WIN7 &&

grt (UTC plus 2) 2017/04/24 09:15:07 please remove this check and "#include "base/win/w

chengx 2017/04/24 17:24:40 Done.

!base::CommandLine::ForCurrentProcess()->HasSwitch(