chrome/browser/win/OWNERS - Issue 2831433003: Time out jumplist update for very slow or busy OS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/win/OWNERS

Issue 2831433003: Time out jumplist update for very slow or busy OS (Closed)

Patch Set: Add myself to be an owner of jumplist* files Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Reviewers:	1 # Reviewers:

2 gab@chromium.org	2 gab@chromium.org

3 grt@chromium.org	3 grt@chromium.org

4 pmonette@chromium.org	4 pmonette@chromium.org

5	5

6 # per-file rules:	6 # per-file rules:

7 per-file chrome_elf_init*=csharp@chromium.org	7 per-file chrome_elf_init*=csharp@chromium.org

8 per-file chrome_elf_init*=robertshield@chromium.org	8 per-file chrome_elf_init*=robertshield@chromium.org

9	9

10 per-file enumerate_modules_model*=finnur@chromium.org	10 per-file enumerate_modules_model*=finnur@chromium.org

11	11

	12 per-file jumplist*=chengx@chromium.org
	Ilya Sherman 2017/04/20 21:24:24 Just to double-check: To whom are you planning to Just to double-check: To whom are you planning to send your code reviews if you're added as an OWNER here? Would it make sense to have multiple owners? Ilya Sherman 2017/04/20 21:24:24 Would it make sense to create a jumplist/ directo Would it make sense to create a jumplist/ directory, rather than adding per-file entries? chengx 2017/04/20 21:49:04 It makes sense to me, but I'm not sure if it's goo Show quoted text On 2017/04/20 21:24:24, Ilya Sherman wrote: > Would it make sense to create a jumplist/ directory, rather than adding > per-file entries? It makes sense to me, but I'm not sure if it's good to create sub-dirs each of which only contains a few files. chengx 2017/04/20 21:49:04 My understanding is that grt@, gab@ and pmonette@ Show quoted text On 2017/04/20 21:24:24, Ilya Sherman wrote: > Just to double-check: To whom are you planning to send your code reviews if > you're added as an OWNER here? Would it make sense to have multiple owners? My understanding is that grt@, gab@ and pmonette@ are owners of all the files in this directory. I'll still send my code reviews to them even after I add myself to the owner of jumplist*.
	13

12 # COMPONENT: Internals>Core	14 # COMPONENT: Internals>Core

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/win/jumplist.cc » ('j') | chrome/browser/win/jumplist.cc » ('J')