sync/internal_api/public/base/unique_position.h - Issue 283143002: sync: Improve handling of bad UniquePos (retry)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/base/unique_position.h

Issue 283143002: sync: Improve handling of bad UniquePos (retry) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/public/base/unique_position.h

diff --git a/sync/internal_api/public/base/unique_position.h b/sync/internal_api/public/base/unique_position.h

index eee53240ab1562124e14ad28d0b2c29fcab36310..b844b823d458bc6822865823a64d304e45de89cb 100644

--- a/sync/internal_api/public/base/unique_position.h

+++ b/sync/internal_api/public/base/unique_position.h

@@ -46,6 +46,10 @@ class SYNC_EXPORT_PRIVATE UniquePosition {

static bool IsValidSuffix(const std::string& suffix);

static bool IsValidBytes(const std::string& bytes);

+ // Returns a valid, but mostly random suffix.

+ // Avoid using this; it can lead to inconsistent sort orderings if misused.

+ static std::string RandomSuffix();

// Returns an invalid position.

static UniquePosition CreateInvalid();