Introduce subresource_filter::ConfigurationList and make querying it cheap.

components/subresource_filter/core/browser/subresource_filter_features.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SUBRESOURCE_FILTER_CORE_BROWSER_SUBRESOURCE_FILTER_FEATURES_H_
 #define COMPONENTS_SUBRESOURCE_FILTER_CORE_BROWSER_SUBRESOURCE_FILTER_FEATURES_H_
 
 #include "base/feature_list.h"
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
 #include "components/subresource_filter/core/common/activation_level.h"
 #include "components/subresource_filter/core/common/activation_list.h"
 #include "components/subresource_filter/core/common/activation_scope.h"
 
 namespace subresource_filter {
 
 // Encapsulates all parameters that define how the subresource filter feature
 // should operate.
 struct Configuration {
   Configuration();
@@ skipping 27 matching lines @@
   bool should_suppress_notifications = false;
 
   // The ruleset flavor to download through the component updater, or the empty
   // string if the default ruleset should be used.
   std::string ruleset_flavor;
 
   // Whether to whitelist a site when a page loaded from that site is reloaded.
   bool should_whitelist_site_on_reload = false;
 };
 
-// Retrieves the subresource filtering configuration to use. Expensive to call.
-Configuration GetActiveConfiguration();
+// TODO(engedy): Make this an actual list once all call sites are prepared to
+// handle multiple simultaneous configurations.
+class ConfigurationList : public base::RefCountedThreadSafe<ConfigurationList> {
+ public:
+  ConfigurationList(Configuration config);

[Sorin Jianu, 2017/04/24 21:58:59]

explicit?

[engedy, 2017/04/25 08:34:24]

Done.

+
+  const Configuration& the_one_and_only() const { return config_; }
+
+ private:
+  friend class base::RefCountedThreadSafe<ConfigurationList>;
+  ~ConfigurationList();
+
+  const Configuration config_;
+
+  DISALLOW_COPY_AND_ASSIGN(ConfigurationList);
+};
+
+// Retrieves all currently enabled subresource filtering configurations. The
+// configurations are parsed on first access and then the result is cached.
+//
+// In tests, however, the config may change in-between navigations, so callers
+// should not hold on to the result for long.
+scoped_refptr<ConfigurationList> GetActiveConfigurations();
+
+namespace testing {
+
+// Clears the cached active ConfigurationList so that it will be recomputed on
+// next access. Used in tests when the variation parameters are altered.
+void ClearCachedActiveConfigurations();
+
+}  // namespace testing
 
 // Feature and variation parameter definitions -------------------------------
 
 // The master toggle to enable/disable the Safe Browsing Subresource Filter.
 extern const base::Feature kSafeBrowsingSubresourceFilter;
 
 // Enables the new experimental UI for the Subresource Filter.
 extern const base::Feature kSafeBrowsingSubresourceFilterExperimentalUI;
 
 // Name/values of the variation parameter controlling maximum activation level.
@@ skipping 16 matching lines @@
 
 extern const char kPerformanceMeasurementRateParameterName[];
 
 extern const char kSuppressNotificationsParameterName[];
 
 extern const char kWhitelistSiteOnReloadParameterName[];
 
 }  // namespace subresource_filter
 
 #endif  // COMPONENTS_SUBRESOURCE_FILTER_CORE_BROWSER_SUBRESOURCE_FILTER_FEATURES_H_