Add Flash binary path option to bisect script.

Add Flash binary path option to bisect script.

Also fix some style/pylint violations.

BUG=None.
TEST=To bisect an unrelated Flash issue ran
./bisect-builds.py -f /opt/google/chrome/PepperFlash/libpepflashplayer.so -b 232915 -g 230425 -a linux64
python bisect-builds.py -f "C:\Program Files (x86)\Google\Chrome\Application\31.0.1650.39\PepperFlash\pepflashplayer.dll" -b 232915 -g 230425 -a win

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234087

[ilja, 2013-11-07 00:30:15]

Could you please review or suggest somebody more familiar with the code? It is
fairly simple though.

[hshi1, 2013-11-07 22:56:34]

On 2013/11/07 00:30:15, ilja wrote:
> Could you please review or suggest somebody more familiar with the code? It is
> fairly simple though.

LGTM but someone more familiar with this script should review this too. Thanks

[enne (OOO), 2013-11-07 23:05:22]

I don't think anybody really owns this script.  I touched it once, so here's an
lgtm from me too.

https://codereview.chromium.org/28313002/diff/170001/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://codereview.chromium.org/28313002/diff/170001/tools/bisect-builds.py#n...
tools/bisect-builds.py:375:
testargs.append('--ppapi-flash-version=99.9.999.999')
Is this impossible to do in Chrome?

[ilja, 2013-11-08 06:07:38]

rsesek: Please owner review!

https://codereview.chromium.org/28313002/diff/170001/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://codereview.chromium.org/28313002/diff/170001/tools/bisect-builds.py#n...
tools/bisect-builds.py:375:
testargs.append('--ppapi-flash-version=99.9.999.999')
Yes. It actually is a command line parameter that is baked into each launch. It
is mostly harmless, if the number is too small Chrome will refuse loading Flash
for security reasons. (If it did load it it could ask it for the version but I
guess this is not done.)

[Robert Sesek, 2013-11-08 18:35:44]

https://codereview.chromium.org/28313002/diff/170001/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://codereview.chromium.org/28313002/diff/170001/tools/bisect-builds.py#n...
tools/bisect-builds.py:365: testargs.append('--flag-switches-begin')
Why do you need --flag-switches-begin?

https://codereview.chromium.org/28313002/diff/170001/tools/bisect-builds.py#n...
tools/bisect-builds.py:368: context.flash_path):
Is this the intended condition? Can you add another set of parens to clarify it?

[ilja, 2013-11-08 19:38:39]

https://codereview.chromium.org/28313002/diff/170001/tools/bisect-builds.py
File tools/bisect-builds.py (right):

https://codereview.chromium.org/28313002/diff/170001/tools/bisect-builds.py#n...
tools/bisect-builds.py:365: testargs.append('--flag-switches-begin')
I will try this on Windows again, I thought it needed it.

[ilja, 2013-11-08 21:12:23]

It turns out I didn't need this or the no-sandbox on Windows which simplifies
things.

Thanks and PTAL.

[Robert Sesek, 2013-11-09 00:52:09]

LGTM

[commit-bot: I haz the power, 2013-11-09 01:04:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ihf@chromium.org/28313002/310001

[commit-bot: I haz the power, 2013-11-09 04:23:02]

Change committed as 234087