Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

Issue 2831183003: Fix loading success.html at the end of chrome://chrome-signin flow (Closed)
Patch Set: Add missing expect Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/url_request_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc b/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
index 23515fd9c2b79cda1183a074463a5311120b976e..3cfad7ed6ea0591fc03c3a0875f6c61a8657de2a 100644
--- a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
@@ -865,6 +865,33 @@ IN_PROC_BROWSER_TEST_F(InlineLoginUISafeIframeBrowserTest, NoWebUIInIframe) {
ui_test_utils::NavigateToURL(browser(), url);
}
+// Make sure that "success.html" can be loaded by chrome://chrome-signin.
+// http://crbug.com/709117
+IN_PROC_BROWSER_TEST_F(InlineLoginUISafeIframeBrowserTest,
+ LoadSuccessContinueURL) {
+ ui_test_utils::NavigateToURL(browser(), GetSigninPromoURL());
+ WaitUntilUIReady(browser());
+
+ const std::string success_url =
+ GaiaUrls::GetInstance()->signin_completed_continue_url().spec();
+ const char* kLoadSuccessPageScript =
+ "var handler = function(e) {"
+ " if (e.url == '%s') {"
+ " window.domAutomationController.send('success_page_loaded');"
+ " }"
+ "};"
+ "var extension_webview = inline.login.getAuthExtHost().webview_;"
+ "extension_webview.addEventListener('loadcommit', handler);"
+ "extension_webview.src = '%s';";
+ std::string script = base::StringPrintf(
+ kLoadSuccessPageScript, success_url.c_str(), success_url.c_str());
+
+ std::string message;
+ ASSERT_TRUE(content::ExecuteScriptAndExtractString(
+ browser()->tab_strip_model()->GetActiveWebContents(), script, &message));
+ EXPECT_EQ("success_page_loaded", message);
+}
+
// Make sure that the gaia iframe cannot trigger top-frame navigation.
// TODO(guohui): flaky on trybot crbug/364759.
IN_PROC_BROWSER_TEST_F(InlineLoginUISafeIframeBrowserTest,
« no previous file with comments | « no previous file | extensions/browser/url_request_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698