Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: extensions/common/manifest_handlers/webview_info.cc

Issue 2831183003: Fix loading success.html at the end of chrome://chrome-signin flow (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/manifest_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest_handlers/webview_info.cc
diff --git a/extensions/common/manifest_handlers/webview_info.cc b/extensions/common/manifest_handlers/webview_info.cc
index 57a5aa01f79a8f9de0c13d16c95cc97cb5fef946..e5cb79362b2a8a1296cceef151105020d545ffe3 100644
--- a/extensions/common/manifest_handlers/webview_info.cc
+++ b/extensions/common/manifest_handlers/webview_info.cc
@@ -72,16 +72,23 @@ bool WebviewInfo::IsResourceWebviewAccessible(
const WebviewInfo* webview_info = static_cast<const WebviewInfo*>(
extension->GetManifestData(keys::kWebviewAccessibleResources));
- if (!webview_info)
+ if (!webview_info) {
+ LOG(ERROR) << "IsResourceWebviewAccessible " << extension->id()
+ << " to load " << relative_path << "? false 1 ";
return false;
+ }
for (const auto& item : webview_info->partition_items_) {
if (item->Matches(partition_id) &&
extension->ResourceMatches(item->accessible_resources(),
relative_path)) {
+ LOG(ERROR) << "IsResourceWebviewAccessible " << extension->id()
+ << " to load " << relative_path << "? true";
return true;
}
}
+ LOG(ERROR) << "IsResourceWebviewAccessible " << extension->id() << " to load "
+ << relative_path << "? false 2";
return false;
}
@@ -91,12 +98,14 @@ void WebviewInfo::AddPartitionItem(std::unique_ptr<PartitionItem> item) {
}
WebviewHandler::WebviewHandler() {
+ LOG(ERROR) << "Create WebviewHandler";
}
WebviewHandler::~WebviewHandler() {
}
bool WebviewHandler::Parse(Extension* extension, base::string16* error) {
+ LOG(ERROR) << "Parse WebviewInfo for extension " << extension->id();
std::unique_ptr<WebviewInfo> info(new WebviewInfo(extension->id()));
const base::DictionaryValue* dict_value = NULL;
@@ -166,6 +175,8 @@ bool WebviewHandler::Parse(Extension* extension, base::string16* error) {
info->AddPartitionItem(std::move(partition_item));
}
+ LOG(ERROR) << "SetManifestData (kWebviewAccessibleResources)"
+ << extension->id() << " Done";
extension->SetManifestData(keys::kWebviewAccessibleResources,
std::move(info));
return true;
« no previous file with comments | « extensions/common/manifest_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698