Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1974)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java

Issue 2831113002: [Suggestions] Add User action UMA for context menu actions (Closed)
Patch Set: "Refactor" Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java
index b3d078b387df8e40d788beedc8de93c0e1cbb58f..8de1e4e2641c3ba5847f755384762032144bc45f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java
@@ -13,6 +13,7 @@ import android.view.MenuItem;
import android.view.MenuItem.OnMenuItemClickListener;
import android.view.View;
+import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
import org.chromium.chrome.browser.suggestions.SuggestionsNavigationDelegate;
@@ -123,6 +124,8 @@ public class ContextMenuManager implements OnCloseContextMenuListener {
// https://crbug.com/638555, https://crbug.com/636296).
mTouchEnabledDelegate.setTouchEnabled(false);
mContextMenuOpen = true;
+
+ RecordUserAction.record("Suggestions.ContextMenu.Shown");
}
@Override
@@ -184,18 +187,23 @@ public class ContextMenuManager implements OnCloseContextMenuListener {
switch (item.getItemId()) {
case ID_OPEN_IN_NEW_WINDOW:
mDelegate.openItem(WindowOpenDisposition.NEW_WINDOW);
+ RecordUserAction.record("Suggestions.ContextMenu.OpenItemInNewWindow");
return true;
case ID_OPEN_IN_NEW_TAB:
mDelegate.openItem(WindowOpenDisposition.NEW_BACKGROUND_TAB);
+ RecordUserAction.record("Suggestions.ContextMenu.OpenItemInNewTab");
return true;
case ID_OPEN_IN_INCOGNITO_TAB:
mDelegate.openItem(WindowOpenDisposition.OFF_THE_RECORD);
+ RecordUserAction.record("Suggestions.ContextMenu.OpenItemInIncognitoTab");
return true;
case ID_SAVE_FOR_OFFLINE:
mDelegate.openItem(WindowOpenDisposition.SAVE_TO_DISK);
+ RecordUserAction.record("Suggestions.ContextMenu.DownloadItem");
return true;
case ID_REMOVE:
mDelegate.removeItem();
+ RecordUserAction.record("Suggestions.ContextMenu.RemoveItem");
return true;
default:
return false;
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698